Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracepipe flags updated #329

Open
XieGuochao opened this issue Jul 3, 2023 · 0 comments
Open

Tracepipe flags updated #329

XieGuochao opened this issue Jul 3, 2023 · 0 comments

Comments

@XieGuochao
Copy link

Root Cause

Since commit, a new flag migrate-disable delay has been added to the tracepipe flag.

Error

The current regex does not well to parse with the additional flag bit.

// A line from trace_pipe looks like (leading spaces included):
// `        chromium-15581 [000] d... 92783.722567: : Hello, World!`
var traceLineRegexp = regexp.MustCompile(`(.{16})-(\d+) +\[(\d{3})\] (.{4}) +(\d+\.\d+)\: (.*?)\: (.*)`)

Solution

Making the flag length variable can resolve this issue. I can create a PR for this.
For example, (.{4}) should be (.{4,}).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant