Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOST Improvement Proposal 1 (token721.iost) #1125

Open
nujabes403 opened this issue Dec 11, 2019 · 2 comments
Open

IOST Improvement Proposal 1 (token721.iost) #1125

nujabes403 opened this issue Dec 11, 2019 · 2 comments

Comments

@nujabes403
Copy link
Contributor

nujabes403 commented Dec 11, 2019

I have 2 requests to IOST Dev team.

image
https://github.com/iost-official/go-iost/blob/master/rpc/pb/rpc.pb.go#L3578

# Request 1. Please add "fromBlock", "toBlock", and "tokenSymbol" parameters to SubscribeRequest_Filter.

  1. Why you need "fromBlock", "toBlock": When a contract, such as token.iost or token721.iost, manages a lot of tokens, there are so many events and receipts.
    Because of this, when you subscribe to these, it's too big and hard to handle the response coming over the network.
    You need to add the "fromBlock" and "toBlock" parameters to get a filtered data.

  2. Why you need a "tokenSymbol": Similar to the above, token.iost or token721.iost is a contract that manages several tokens.
    For example, when you need events from "rat" NFT in token721.iost, there is no way to get a filtered events only related to "rat" NFT.

# Request 2. Force the "transfer" event to occur in the "issue" and "transfer" functions of the token721.iost base contract.
In the Ethereum ERC721 specification, the "Transfer" event is always triggered when the "issue" or "transfer" function is executed.
This is very useful when creating a service, like NFT Market or NFT Wallet, that needs to show all the NFTs that the user has since tracking the NFT token's movement is possible.

@nujabes403
Copy link
Contributor Author

nujabes403 commented Dec 11, 2019

@nujabes403
Copy link
Contributor Author

@nujabes403 nujabes403 changed the title IOST Improvement Proposal (token721.iost) IOST Improvement Proposal 1 (token721.iost) Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant