Skip to content

chore(deps): update ionic-docs to React 19 and other dependencies #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion _templates/playground/new/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ module.exports = {

const playgroundName = changeCase.pascal(answers.path.split('/').pop());
console.log(
`\nTo use this playground in a docs markdown file, include\nthe following:\n\n## ${playgroundName}\n\nimport ${playgroundName} from '@site/static/usage/v${answers.version}/${answers.name}/${answers.path}/index.md';\n\n<${playgroundName} />\n`
`\nTo use this playground in a docs markdown file, include\nthe following:\n\n## ${playgroundName}\n\nimport ${playgroundName} from '@site/static/usage/v${answers.version}/${answers.name}/${answers.path}/index.md';\n\n<${playgroundName} />\n`,
);

return answers;
Expand Down
2 changes: 1 addition & 1 deletion docs/core-concepts/webview.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import { Capacitor } from '@capacitor/core';
Capacitor.convertFileSrc(filePath);
```

For Cordova apps, the [Ionic Web View plugin](https://github.com/ionic-team/cordova-plugin-ionic-webview) provides a utility function for converting File URIs: `window.Ionic.WebView.convertFileSrc()`. There is also a corresponding Ionic Native plugin: [`@awesome-cordova-plugins/ionic-webview`](../native/ionic-webview.md).
For Cordova apps, the [Ionic Web View plugin](https://github.com/ionic-team/cordova-plugin-ionic-webview) provides a utility function for converting File URIs: `window.Ionic.WebView.convertFileSrc()`. There is also a corresponding Ionic Native plugin: `@awesome-cordova-plugins/ionic-webview`.

### Implementations

Expand Down
11 changes: 6 additions & 5 deletions docs/developer-resources/guides/first-app-v4/intro.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ Download/install these right away to ensure an optimal Ionic development experie

- [Git](https://git-scm.com/downloads) for version control.
- <strong>SSH client</strong>, such as [PuTTy](https://www.putty.org/), for secure login to Appflow.
- <strong>Node.js</strong> for interacting with the Ionic ecosystem. [Download the LTS version here](https://nodejs.org/en/).
- <strong>A code editor</strong> for... writing code! We are fans of [Visual Studio Code](https://code.visualstudio.com/).
- <strong>Node.js</strong> for interacting with the Ionic ecosystem. [Download the LTS version
here](https://nodejs.org/en/).
- <strong>A code editor</strong> for... writing code! We are fans of [Visual Studio
Code](https://code.visualstudio.com/).
- <strong>Command-line terminal (CLI)</strong>: FYI <strong>Windows</strong> users, for the best Ionic experience, we
recommend the built-in command line (cmd) or the Powershell CLI, running in Administrator mode. For <strong>
Mac/Linux
</strong> users, virtually any terminal will work.
recommend the built-in command line (cmd) or the Powershell CLI, running in Administrator mode. For
<strong>Mac/Linux</strong> users, virtually any terminal will work.

## Install Ionic and Cordova

Expand Down
2 changes: 1 addition & 1 deletion docs/react/navigation.md
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ type UseIonRouterResult = {
routerDirection?: RouterDirection,
routeAction?: RouteAction,
routerOptions?: RouterOptions,
animationBuilder?: AnimationBuilder
animationBuilder?: AnimationBuilder,
): void;
/**
* Navigates backwards in history, using the IonRouter to determine history
Expand Down
2 changes: 1 addition & 1 deletion docs/react/testing/unit-testing/best-practices.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ test('example', async () => {
render(
<IonApp>
<Example />
</IonApp>
</IonApp>,
);

await user.click(screen.getByRole('button', { name: /click me!/i }));
Expand Down
4 changes: 2 additions & 2 deletions docs/react/testing/unit-testing/examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('button presents a modal when clicked', async () => {
render(
<IonApp>
<Example />
</IonApp>
</IonApp>,
);
// Simulate a click on the button
fireEvent.click(screen.getByText('Open'));
Expand Down Expand Up @@ -99,7 +99,7 @@ test('should present ModalContent when button is clicked', async () => {
render(
<IonApp>
<Example />
</IonApp>
</IonApp>,
);
// Simulate a click on the button
fireEvent.click(screen.getByText('Open'));
Expand Down
8 changes: 4 additions & 4 deletions docs/reference/browser-support.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ Ionic supports the following browsers:

| Browser | Ionic v8 | Ionic v7 | Ionic v6 | Ionic v5 | Ionic v4 |
| :---------: | :------: | :------: | :------: | :------: | :------: |
| **Chrome** | 89+ | 79+ | 60+ | ✔ | ✔ |
| **Safari** | 15+ | 14+ | 13+ | ✔ | ✔ |
| **Edge** | 89+ | 79+ | 79+ | 79+ | ✔ |
| **Firefox** | 75+ | 70+ | 63+ | ✔ | ✔ |
| **Chrome** | 89+ | 79+ | 60+ | ✔ | ✔ |
| **Safari** | 15+ | 14+ | 13+ | ✔ | ✔ |
| **Edge** | 89+ | 79+ | 79+ | 79+ | ✔ |
| **Firefox** | 75+ | 70+ | 63+ | ✔ | ✔ |
| **IE 11** | **X** | **X** | **X** | **X** | **X** |
2 changes: 2 additions & 0 deletions docs/reference/support.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ The Ionic team has compiled a set of recommendations for using the Ionic Framewo
| v3 | v5.2.11 | v5.2.11 | 2.6.2 |

[^1]: Angular 14.x supported starting in Ionic v6.1.9. Angular 15.x supported starting in Ionic v6.3.6.

[^2]: Angular 17.x supported starting in Ionic v7.5.4.

[^3]: Angular 18.x supported starting in Ionic v8.2.0.

**Angular 13+ Support On Older Versions of iOS**
Expand Down
2 changes: 1 addition & 1 deletion docs/vue/pwa.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ if (process.env.NODE_ENV === 'production') {
register(`${process.env.BASE_URL}service-worker.js`, {
ready() {
console.log(
'App is being served from cache by a service worker.\n' + 'For more details, visit https://goo.gl/AFskqB'
'App is being served from cache by a service worker.\n' + 'For more details, visit https://goo.gl/AFskqB',
);
},
registered() {
Expand Down
5 changes: 2 additions & 3 deletions docusaurus.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const path = require('path');
const prismic = require('@prismicio/client');
const fetch = require('node-fetch');

const VERSIONS_JSON = require('./versions.json');

Expand Down Expand Up @@ -71,7 +70,7 @@ module.exports = {
if ((match = docPath.match(/cli\/commands\/(.*)\.md/)) != null) {
return `https://github.com/ionic-team/ionic-cli/edit/develop/packages/@ionic/cli/src/commands/${match[1].replace(
'-',
'/'
'/',
)}.ts`;
}
if ((match = docPath.match(/native\/(.*)\.md/)) != null) {
Expand Down Expand Up @@ -353,7 +352,7 @@ module.exports = {
name: 'ionic-docs-ads',
async loadContent() {
const repoName = 'ionicframeworkcom';
const endpoint = prismic.getEndpoint(repoName);
const endpoint = `https://${repoName}.prismic.io/api/v2`;
const client = prismic.createClient(endpoint, {
fetch,
});
Expand Down
Loading
Loading