Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: socket progress events should be handled by translation system #7792

Open
1 task done
psychedelicious opened this issue Mar 14, 2025 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@psychedelicious
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Contact Details

No response

What should this feature add?

When we emit progress events during graph execution, they can have a message attached.

In the UI, we display that message. Currently, the messages are displayed as-is, without any means to be translated.

We can improve on this:

  • Core nodes should use translation keys for progress event messages.
  • The frontend should render the messages using the translation function.
  • If the message is a valid translation key, any translation will be used. We will ensure that the core nodes' progress messages have an English translation.
  • If they message is not a valid translation key (i.e. it is just "normal" English words), the translation function will fall back to outputting the message as is.

Alternatives

No response

Additional Content

No response

@psychedelicious psychedelicious added the enhancement New feature or request label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant