fix: cursor and newline missing when running without --watch #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrousselGit
reviewed
Feb 8, 2023
| return sub.read() | ||
| ..then((_) => stdout | ||
| ..write(VT100.showCursor) | ||
| ..write('\n')); |
There was a problem hiding this comment.
Otherwise this problem occurs.
rrousselGit
reviewed
Feb 8, 2023
| @@ -231,7 +231,12 @@ Future<int> spec({ | |||
| final sub = ref.listen($exitCode.future, (previous, current) {}); | |||
|
|
|||
| // Outside of watch mode, quit as soon we know what the exit code should be | |||
| return sub.read(); | |||
| return () { | |||
There was a problem hiding this comment.
This function block is unnecessary. You don't have to put everything on the return keyword
|
Thanks! |
rrousselGit
changed the title
|
Do you mind writing a test for this? As an example, you can look at You might have to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Changes proposed
Apparently the
finallyblock containingVT100.showCursorandVT100.newlinewas not executed because the function was beingreturned from within thetryblock.Now it's fixed. I didn't write tests for it because I'm not familiar with this project's codebase at all.
Check List (Check all the applicable boxes)