-
|
Firestore added a nice feature that lets us search for fields that exits/don't and seems like react-native-firebase doesn't use the latest version. It would be awesome to have this as the current method is complicated especially if you have two where queries |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 4 replies
-
|
I saw that as well! This would be great, we'd love a PR to implement it. It isn't even that hard I think - here is a template doing the same for the last batch of operators they added, so it can be followed as a guide: https://github.com/invertase/react-native-firebase/pull/2868/files (that PR is mostly big because it moved the SDK dependencies up to the level that supports the new queries, the actual implementation isn't huge) Note that to develop for react-native-firebase isn't too hard either - the "tests" folder has a README explaining how to get tests running, then you open Xcode or Android Studio on the "tests" directory as if it were an app you were developing, and the native code (plus javascript of course) is available through it's dependencies into the other modules. It ends up being pretty breezy, or at least as breezy as developing any react-native app is |
Beta Was this translation helpful? Give feedback.
-
|
Will be supported in #4474 |
Beta Was this translation helpful? Give feedback.
-
|
As a side note, both the Android & iOS Firebase SDKs will need to have this supported first before RNFirebase can, I'd be surprised if they both already support it, usually a couple weeks behind JS SDK. |
Beta Was this translation helpful? Give feedback.
-
|
They were quick on that one, with android release yesterday they both have it already: |
Beta Was this translation helpful? Give feedback.
-
|
Only testing complexity I think is to make sure this constraint is explicit in the API doc if we get a PR " Neither query operator will match documents where the specified field is not present." |
Beta Was this translation helpful? Give feedback.
-
|
cc @russellwheatley may interest you if you want to implement a couple of new query features, for RNF & FF 🤓 |
Beta Was this translation helpful? Give feedback.
I saw that as well! This would be great, we'd love a PR to implement it. It isn't even that hard I think - here is a template doing the same for the last batch of operators they added, so it can be followed as a guide: https://github.com/invertase/react-native-firebase/pull/2868/files
(that PR is mostly big because it moved the SDK dependencies up to the level that supports the new queries, the actual implementation isn't huge)
Note that to develop for react-native-firebase isn't too hard either - the "tests" folder has a README explaining how to get tests running, then you open Xcode or Android Studio on the "tests" directory as if it were an app you were developing, and the native code …