Skip to content

Commit 9d2a393

Browse files
committed
fix(analytics, ios): reject getSessionId call if id is zero
See firebase/firebase-ios-sdk#15258
1 parent f8d5a9d commit 9d2a393

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

packages/analytics/ios/RNFBAnalytics/RNFBAnalyticsModule.m

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,13 @@ - (dispatch_queue_t)methodQueue {
129129
: (RCTPromiseResolveBlock)resolve rejecter
130130
: (RCTPromiseRejectBlock)reject) {
131131
[FIRAnalytics sessionIDWithCompletion:^(int64_t sessionID, NSError *_Nullable error) {
132+
// Occasionally sessionID is 0 despite nil error, reject as if it were an error
133+
// https://github.com/firebase/firebase-ios-sdk/issues/15258
134+
if (!error && [NSNumber numberWithLongLong:sessionID] == 0) {
135+
DLog(@"Error getting session ID: sessionID is zero despite nil error");
136+
return resolve([NSNull null]);
137+
}
138+
132139
if (error) {
133140
DLog(@"Error getting session ID: %@", error);
134141
return resolve([NSNull null]);

0 commit comments

Comments
 (0)