fix(analytics, messaging): dedupe GoogleUtilities classes under SPM dynamic frameworks

Under Expo's SPM + dynamic frameworks path, RNFBAnalytics.podspec and
RNFBMessaging.podspec only declared their direct Firebase SPM products
(FirebaseAnalytics, FirebaseMessaging). GULNetwork, GULReachability, and
GULMethodSwizzler were only reachable transitively through those, and
Xcode's SPM integration doesn't reliably promote a transitively-only
reached product to a shared PackageProduct.framework. It compiled a
private copy of each straight into RNFBAnalytics.framework and
RNFBMessaging.framework instead, so GULNetwork/GULMutableDictionary/
GULNetworkURLSession/GULReachabilityChecker/GULSessionDeallocTracker/
GULSwizzler ended up defined twice at runtime once both pods were loaded.

The fix declares those same GoogleUtilities products as an explicit
top-level spm_dependency on both podspecs, the same way GULAppDelegateSwizzler
already was. That's enough for Xcode to treat them as shared and build one
dynamic framework per product instead of duplicating them.

test-expo-ios-link.sh gained a new #9322 check that walks every built
.framework, nm's its defined external symbols, and fails if any of the
affected GUL classes are defined in more than one framework or privately
inside any RNFB* framework rather than a shared PackageProduct. Also removed
the hardcoded CC=clang/LD=clang xcodebuild args, which broke pure-Swift SPM
targets pulled in by this repro (FirebaseCoreInternal).

test-expo's package list and the closer's RNFB* target discovery are already
on main, so this commit does not touch them. The #9322 check still runs
against that graph. Every watched GUL class, including the two
SWIFTPM_MODULE_BUNDLER_FINDER symbols, has exactly one owner, and that owner
is never an RNFB* framework.

Added a short OKF note in ios-spm-native-imports.md: explicit GoogleUtilities
products can share a PackageProduct. That does not extend to FirebaseCore/
FIRApp.

Author: russellwheatley

.github/workflows/scripts/test-expo-ios-link.sh

@@ -257,7 +257,6 @@ xcodebuild_args=(
   ARCHS="${HOST_ARCH}"
   VALID_ARCHS="${HOST_ARCH}"
   ONLY_ACTIVE_ARCH=YES
-  CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++
   -workspace "$WORKSPACE"
   -scheme "$SCHEME"
   -configuration Release
@@ -303,3 +302,82 @@ if grep -q "duplicate symbol '_FIRFirebaseVersion'" "$XCODEBUILD_LOG" ||
 fi
 
 log "PASS: Expo documented path links RNFBApp/RNFBMessaging as frameworks without duplicate Firebase symbols"
+
+# #9322: without an explicit top-level spm_dependency declaration on
+# RNFBAnalytics.podspec / RNFBMessaging.podspec (see the comments there for
+# the full writeup, including what's confirmed vs. still an open question),
+# GoogleUtilities classes (GULNetwork, GULReachabilityChecker, etc.) end up
+# compiled privately into both RNFBAnalytics.framework and
+# RNFBMessaging.framework instead of one shared dynamic framework, and
+# collide at runtime once both are loaded in-process.
+#
+# Requires @react-native-firebase/analytics alongside messaging in
+# test-expo/package.json to actually exercise both sides of the graph.
+log "--- #9322 GoogleUtilities dedupe diagnosis ---"
+BUILT_PRODUCTS_DIR="$(grep -oE '/[^ ]*/Build/Products/[A-Za-z0-9_.-]+' "$XCODEBUILD_LOG" | head -1 || true)"
+if [[ -z "$BUILT_PRODUCTS_DIR" || ! -d "$BUILT_PRODUCTS_DIR" ]]; then
+  log "ERROR: could not determine BUILT_PRODUCTS_DIR from xcodebuild log for #9322 check"
+  exit 1
+fi
+
+nine322_classes=(
+  GULNetwork
+  GULMutableDictionary
+  GULNetworkURLSession
+  GULNetworkURLSessionWeakHolder
+  GULSessionDeallocTracker
+  GULReachabilityChecker
+  GULSwizzler
+  GoogleUtilities_GoogleUtilities_Network_SWIFTPM_MODULE_BUNDLER_FINDER
+  GoogleUtilities_GoogleUtilities_Reachability_SWIFTPM_MODULE_BUNDLER_FINDER
+)
+
+nine322_work_dir="$(mktemp -d)"
+trap 'rm -rf "$nine322_work_dir"' EXIT
+
+while IFS= read -r fw_dir; do
+  fw_name="$(basename "$fw_dir" .framework)"
+  bin="$fw_dir/$fw_name"
+  [[ -f "$bin" ]] || continue
+  fw_syms="$(nm -gU "$bin" 2>/dev/null || true)"
+  [[ -z "$fw_syms" ]] && continue
+  for class_name in "${nine322_classes[@]}"; do
+    if grep -qE '_OBJC_CLASS_\$_'"${class_name}"'$' <<<"$fw_syms"; then
+      echo "$fw_name" >>"${nine322_work_dir}/${class_name}.txt"
+    fi
+  done
+done < <(find "$BUILT_PRODUCTS_DIR" -type d -name "*.framework" ! -path "*/*.app/*" 2>/dev/null)
+
+nine322_failed=0
+for class_name in "${nine322_classes[@]}"; do
+  owners_file="${nine322_work_dir}/${class_name}.txt"
+  if [[ ! -f "$owners_file" ]]; then
+    log "ERROR: #9322 -- ${class_name} not defined in any built framework"
+    nine322_failed=1
+    continue
+  fi
+  owner_count="$(wc -l <"$owners_file" | tr -d ' ')"
+  owners="$(tr '\n' ' ' <"$owners_file")"
+  if [[ "$owner_count" -ne 1 ]]; then
+    log "ERROR: #9322 -- expected exactly 1 framework defining ${class_name}, found ${owner_count}: ${owners}"
+    nine322_failed=1
+    continue
+  fi
+  case "$owners" in
+    RNFB*)
+      log "ERROR: #9322 -- ${class_name} is privately duplicated into ${owners} instead of a shared framework"
+      nine322_failed=1
+      ;;
+    *)
+      log "ok: ${class_name} shared in ${owners}"
+      ;;
+  esac
+done
+log "--- end #9322 GoogleUtilities dedupe diagnosis ---"
+
+if [[ "$nine322_failed" -ne 0 ]]; then
+  log "ERROR: #9322 GoogleUtilities duplicate-class regression detected"
+  exit 1
+fi
+
+log "PASS: no RNFB* framework privately duplicates a shared GoogleUtilities class (#9322)"

okf-bundle/ios-spm-native-imports.md

@@ -248,6 +248,30 @@ CocoaPods-only `IdentitySupport` on the SPM path.
 Consumer-facing version pin and `-ObjC` notes:
 [`docs/ios-spm.mdx`](../docs/ios-spm.mdx).
 
+### GoogleUtilities: explicit `spm_dependency` lets pods share one product
+
+The FirebaseCore limitation above is about *automatic* SPM products declared
+only transitively. A related but narrower case: some `GoogleUtilities`
+products (`GULNetwork`, `GULReachability`, `GULMethodSwizzler`) were only
+reachable transitively through `FirebaseAnalytics`/`FirebaseMessaging` on
+`RNFBAnalytics.podspec`/`RNFBMessaging.podspec`, and Xcode's SPM integration
+did not reliably promote them to a shared `PackageProduct.framework` in that
+graph — each pod compiled a private copy instead, colliding at runtime once
+both were loaded (GitHub
+[#9322](https://github.com/invertase/react-native-firebase/issues/9322)).
+
+Declaring the same GoogleUtilities products as an explicit top-level
+`spm_dependency` directly on each consuming podspec (same pattern as the
+existing `GULAppDelegateSwizzler` declaration) is enough for Xcode to build
+one shared dynamic framework per product and link every consumer against it,
+instead of duplicating it per pod. This is scoped to `GoogleUtilities`
+products specifically; it does **not** change or fix the `FirebaseCore`/
+`FIRApp` sharing limitation described above, which stays unsupported under
+SPM regardless of how explicitly any product is declared. Add this
+declaration only to podspecs actually shown to privately duplicate a watched
+class by `yarn test-expo:ios:link`'s `#9322` diagnosis, not pre-emptively to
+every RNFB podspec.
+
 ## App target FirebaseCore link: package dependency alone is not enough
 
 `rnfirebase_add_spm_core_to_app_target` exists for the case in the table above

packages/analytics/RNFBAnalytics.podspec

@@ -67,6 +67,49 @@ Pod::Spec.new do |s|
     firebase_dependency(s, firebase_sdk_version, ['FirebaseAnalytics'], 'FirebaseAnalytics/Core')
   end
 
+  # SPM: fix for #9322 -- GULNetwork/GULReachability/GULMethodSwizzler ended
+  # up compiled privately into both RNFBAnalytics.framework and
+  # RNFBMessaging.framework instead of one shared dynamic framework,
+  # producing duplicate ObjC class definitions (GULNetwork,
+  # GULMutableDictionary, GULNetworkURLSession, GULReachabilityChecker,
+  # GULSessionDeallocTracker, GULSwizzler) at runtime once both frameworks
+  # are loaded together.
+  #
+  # Confirmed: the raw FirebaseAnalytics/GoogleAppMeasurement .xcframework
+  # binaries do NOT bake in their own copies of these classes (checked via
+  # `nm`); they only reference them as undefined externals, same as any
+  # source-based product.
+  #
+  # Not fully confirmed: *why* Xcode's SPM integration fails to promote this
+  # specific cluster to a shared PackageProduct.framework once RNFBAnalytics
+  # is in the graph, when an equivalent pure-source pairing (RNFBMessaging +
+  # RNFBAuth, sharing the GULAppDelegateSwizzler cluster instead) promotes
+  # cleanly with no private copies at all. It isn't simply "declared
+  # transitively vs explicitly" either: firebase-ios-sdk's own Package.swift
+  # already lists GULNetwork/GULMethodSwizzler as explicit top-level
+  # products on FirebaseAnalyticsWrapper, in the same dependency array as
+  # GULAppDelegateSwizzler, and only the latter shared correctly. Whether
+  # Analytics's target also carrying a binaryTarget dependency is what
+  # changes Xcode's per-target sharing heuristic here is a live, untested
+  # hypothesis, not something this fix confirms or rules out.
+  #
+  # What IS confirmed: declaring these same products as an explicit
+  # top-level SPM dependency directly on *this* podspec (and on
+  # RNFBMessaging.podspec) makes Xcode build one shared dynamic framework
+  # per product and link both RNFBAnalytics and RNFBMessaging against it,
+  # instead of each compiling its own copy. Verified with a passing run
+  # (fix applied) and a failing negative control (fix reverted).
+  if defined?(spm_dependency) && !rnfirebase_spm_disabled?
+    # 8.1.3 floor matches the GoogleUtilities version firebase-ios-sdk 12.x
+    # resolves transitively; bump this alongside firebase_sdk_version if
+    # firebase-ios-sdk ever moves to GoogleUtilities 9.x.
+    spm_dependency(s,
+      url: 'https://github.com/google/GoogleUtilities.git',
+      requirement: { kind: 'upToNextMajorVersion', minimumVersion: '8.1.3' },
+      products: ['GULNetwork', 'GULReachability', 'GULMethodSwizzler']
+    )
+  end
+
   unless defined?(spm_dependency) && !rnfirebase_spm_disabled?
     # CocoaPods-only: conditional IdentitySupport subspec
     if defined?($RNFirebaseAnalyticsWithoutAdIdSupport) && ($RNFirebaseAnalyticsWithoutAdIdSupport == true)

packages/messaging/RNFBMessaging.podspec

@@ -65,6 +65,24 @@ Pod::Spec.new do |s|
     ['Firebase/Messaging', 'FirebaseCoreExtension']
   )
 
+  # SPM: fix for #9322 -- see the matching comment in RNFBAnalytics.podspec
+  # for the full writeup, including what's actually confirmed vs. still an
+  # open question about *why* Xcode's SPM integration behaves this way.
+  # RNFBMessaging needs the same explicit top-level declaration for Xcode to
+  # share a single dynamic framework per product instead of privately
+  # duplicating GULNetwork/GULReachabilityChecker/GULSwizzler into
+  # RNFBMessaging.framework too.
+  if defined?(spm_dependency) && !rnfirebase_spm_disabled?
+    # 8.1.3 floor matches the GoogleUtilities version firebase-ios-sdk 12.x
+    # resolves transitively; bump this alongside firebase_sdk_version if
+    # firebase-ios-sdk ever moves to GoogleUtilities 9.x.
+    spm_dependency(s,
+      url: 'https://github.com/google/GoogleUtilities.git',
+      requirement: { kind: 'upToNextMajorVersion', minimumVersion: '8.1.3' },
+      products: ['GULNetwork', 'GULReachability', 'GULMethodSwizzler']
+    )
+  end
+
   if defined?($RNFirebaseAsStaticFramework)
     Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
     s.static_framework = $RNFirebaseAsStaticFramework