Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Cancel with Close btn #350

Closed
ntarocco opened this issue Feb 6, 2025 · 0 comments · Fixed by inveniosoftware/react-invenio-forms#273
Closed

Replace Cancel with Close btn #350

ntarocco opened this issue Feb 6, 2025 · 0 comments · Fixed by inveniosoftware/react-invenio-forms#273
Milestone
CERN Thesis

Comments

@ntarocco
Copy link
Contributor

ntarocco commented Feb 6, 2025

The button here is wrong, it should be Close instead of Cancel. Make sure that icon and style is coherence with other close buttons.

Image
@ntarocco ntarocco added this to the CERN Thesis milestone Feb 6, 2025
ntarocco added a commit to ntarocco/react-invenio-forms that referenced this issue Feb 6, 2025
@ntarocco
custom-fields: replace Cancel with Close btn in modal
eb250fc 
* closes CERNDocumentServer/cds-rdm#350
@ntarocco ntarocco mentioned this issue Feb 6, 2025
Merged
ntarocco added a commit to ntarocco/react-invenio-forms that referenced this issue Feb 6, 2025
@ntarocco
custom-fields: replace Cancel with Close btn in modal
75f97b1 
* closes CERNDocumentServer/cds-rdm#350
@ntarocco ntarocco changed the title Change Cancel to Close btn Replace Cancel with Close btn Feb 6, 2025
ntarocco added a commit to ntarocco/react-invenio-forms that referenced this issue Feb 6, 2025
@ntarocco
custom-fields: replace Cancel with Close btn in modal
cfefc0c 
* closes CERNDocumentServer/cds-rdm#350
@ntarocco ntarocco moved this to In review 🔍 in Sprint Q1/2025 Feb 7, 2025
@github-project-automation github-project-automation bot moved this from In review 🔍 to To release 🤖 in Sprint Q1/2025 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CERN Thesis
Development

Successfully merging a pull request may close this issue.

custom-fields: replace Cancel with Close btn in modal ntarocco/react-invenio-forms
1 participant
@ntarocco