Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if self.icon_key is not a key in current_theme_icons? #310

Open
kpsherva opened this issue Aug 30, 2022 · 0 comments
Open

What happens if self.icon_key is not a key in current_theme_icons? #310

kpsherva opened this issue Aug 30, 2022 · 0 comments

Comments

@kpsherva
Copy link
Contributor

What happens if self.icon_key is not a key in current_theme_icons?

Should this yield an error to warn the developer or should it render the menu entry without its icon?

Originally posted by @alejandromumo in inveniosoftware/invenio-administration#23 (comment)

@kpsherva kpsherva moved this to 🆕 Triage in InvenioRDM v10 - Back-office Aug 30, 2022
@kpsherva kpsherva moved this from 🆕 Triage to 📋 To do in InvenioRDM v10 - Back-office Aug 30, 2022
@kpsherva kpsherva moved this from 📋 To do to 🆕 Triage in InvenioRDM v10 - Back-office Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🆕 Triage
Development

No branches or pull requests

1 participant