Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom fields: marshmallow validation should know which fields were created #355

Closed
ppanero opened this issue Jul 14, 2022 · 1 comment
Closed

custom fields: marshmallow validation should know which fields were created #355

ppanero opened this issue Jul 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ppanero
Copy link
Member

ppanero commented Jul 14, 2022

Currently, once the custom field has been configured in the invenio.cfg file it can already be used:

  • The jsonschema wont complain since custom is an object so is a "catch all"
  • Marshmallow will get the schema from the configured field
  • Elasticsearch will auto detect the type of field <-- here is the problem

Since the field was not created using the CLI the mapping type might not be correct, leading to problems (since it cannot be updated)
@ppanero ppanero added the bug Something isn't working label Jul 14, 2022
@ppanero ppanero moved this from 📋 Todo to 🏗 In Progress in InvenioRDM v10 - Custom Fields Aug 3, 2022
@ppanero ppanero self-assigned this Aug 3, 2022
@ppanero ppanero moved this from 🏗 In Progress to Blocked in InvenioRDM v10 - Custom Fields Aug 4, 2022
@ppanero ppanero removed their assignment Aug 4, 2022
@ppanero ppanero mentioned this issue Aug 4, 2022
Open
@ppanero
Copy link
Member Author

ppanero commented Sep 7, 2022

duplicated to #362

@ppanero ppanero closed this as completed Sep 7, 2022
Repository owner moved this from Blocked to ✅ Done in InvenioRDM v10 - Custom Fields Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
InvenioRDM v10 - Custom Fields
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppanero