Make package part of publish
#770
Conversation
isc-shuliu
requested review from
isc-kiyer,
isc-tleavitt,
isc-eneil,
isc-etamarch,
isc-jili and
isc-jlechtne
| @@ -1296,6 +1296,12 @@ Method %Publish(ByRef pParams) As %Status | |||
| { | |||
| Set tSC = $$$OK | |||
| Try { | |||
| // Perform the "Package" phase to prepare the module for publishing | |||
| // ..Payload is populated by %Package. So need to make sure it's using the same lifecycle object. | |||
| Set pParams("LifecycleObject") = $This | |||
There was a problem hiding this comment.
Q: for multiple phases of a single module, is the lifecycle class not provided in pParams? I understand it isn't for dependencies (and that makes sense) but across ExecutePhases(), it would be passed right?
There was a problem hiding this comment.
Lifecycle is passed in as a string (name of the class or a path on filesystem) in pParams("Lifecycle"). Here we really need to use the same lifecycle object because %Package will write to the ..Payload of the same object and %Publish read from it.
The ..Lifecycle property is transient and created using %New() in %IPM.Storage.Module:LifecycleGet(). Somehow the r%Lifecycle in LifeCycleGet is null when called from %DispatchMethod(), causing the getter method to create a new lifecycle object.
Catch up fix to #767; Implement #769
With this change,
%Packageis part of%Publishand will be called duringpublish <module> -only. This allows publishing the package without running%Reloadphase.