Config script does not save supplied git bin path

[cambot]

I had installed git to a location in my user app directory, so it did not end up in the PATH and Iris does not find it when kicking off d ##class(SourceControl.Git.API).Configure()

if I run $zf(-100) with C:\full\path\to\bin\git.exe --version from an Iris terminal, it can report back the version of git I have installed, even with it being installed in my user app directory.

However, when I provide that folder path to Configure(), it reports "You are now using (blank)".

I did not catch this as a problem at first and got really confused when I encountered <NOTOPEN> errors later in the setup (see here).

Inside SourceControl.Git.Settings.ConfigureBinPath() I see 2 potential improvements:

1. Check the return value of GitBinExists(.version). If nothing is returned: raise alarm bells and hard quit out of the configure process (because the whole point of this module is to set up source control)
2. If the ..gitBinPath property is not set, then the valid supplied path value is not actually saved into @sysStorage

Environment Stats

• git-source-control: v2.11.0
• $zv: IRIS for Windows (x86-64) 2023.1.5 (Build 697U) Thu Oct 3 2024 13:47:51 EDT

[cambot]

One can work around this by setting the bin path directly before running Configure():

set sysStorage = ##class(SourceControl.Git.Utils).%SYSNamespaceStorage()
set @sysStorage@("%gitBinPath") = "C:\direct\path\to\Git\cmd\git.exe"