Skip to content

Configure script fails to clone repository #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cambot opened this issue Apr 21, 2025 · 2 comments
Open

Configure script fails to clone repository #750

cambot opened this issue Apr 21, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@cambot
Copy link

cambot commented Apr 21, 2025

When running do ##class(SourceControl.Git.API).Configure(), the user is prompted to provide an SSH key with this message:

Path to private key file for SSH remotes; if file does not exist, later prompts will help set it up with proper ownership:

If I leave this blank and proceed to clone a repository, I am never prompted to create an SSH key through the script even though this text tells me I should expect that.

Is the SSK Key prompt referring to the GUI (where it sometimes provides a button to facilitate creating a key) or later in the Configure script? Best case is that this instruction just needs clarification. Worst case, this is a feature that is not working as intended.

(for what it's worth, when I first create an SSH key myself and configure the public part in github/bitbucket, the clone process works.)

@isc-pbarton
Copy link
Collaborator

The prompt could definitely use some clarification. The expected behavior here is that:

  • if I do not enter a file path, no SSH key is created
  • if I do enter a file path and the file exists, no SSH key is created
  • if I do enter a file path and the file does not exist, another prompt will show up at the end asking if an SSH key should be created.

How about this as the prompt? "Path to private key file for SSH remotes; if a path is provided and file does not exist, later prompts will help set it up with proper ownership:"

@cambot
Copy link
Author

cambot commented Apr 21, 2025

That's on the right track, but I think we can do better. How about this?

Path to an SSH private key file for remote interactions. (If a path is provided and the file does not exist, then this script will walk you through creating one. Leave blank to skip.)

@isc-pbarton isc-pbarton added the good first issue Good for newcomers label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants