Merge pull request #55 from intersystems/fix-54

fix: defensive coding in ListToBit

Author: isc-tleavitt

.github/workflows/main.yml

@@ -77,7 +77,7 @@ jobs:
         # all tests passed.
         fail: false
     - name: Attach the report
-      uses: actions/upload-artifact@v1
+      uses: actions/upload-artifact@v4
       if: always()
       with:
         name: ${{ steps.xunit-viewer.outputs.report-name }}

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.0.4] - Unreleased
+
+### Fixed 
+- #54: Defend against possible configuration-dependent SQL exceptions in mapping INT to MAC/CLS coverage
+
 ## [4.0.3] - 2024-08-19
 
 ### Fixed 

cls/TestCoverage/Procedures.cls

@@ -82,7 +82,9 @@ ClassMethod ListToBit(pSource As %List) As %Binary [ SqlName = LIST_TO_BIT, SqlP
 	Set tResult = ""
 	Set tPointer = 0
 	While $ListNext(pSource,tPointer,tBitPosition) {
-		Set $Bit(tResult,tBitPosition) = 1
+		If $Data(tBitPosition)#2 && (+tBitPosition > 0) {
+			Set $Bit(tResult,+tBitPosition) = 1
+		}
 	}
 	Quit tResult
 }

internal/testing/unit_tests/UnitTest/TestCoverage/Unit/Procedures.cls

@@ -0,0 +1,13 @@
+Class UnitTest.TestCoverage.Unit.Procedures Extends %UnitTest.TestCase
+{
+
+Method TestListToBit()
+{
+    Set compare = ""
+    For i=1:1:3 {
+        Set $Bit(compare,i) = 1
+    }
+    Do $$$AssertEquals(##class(TestCoverage.Procedures).ListToBit($lb(1,2,3,,"")),compare)
+}
+
+}

module.xml

@@ -2,7 +2,7 @@
 <Export generator="Cache" version="25">
 <Document name="TestCoverage.ZPM"><Module>
   <Name>TestCoverage</Name>
-  <Version>4.0.3</Version>
+  <Version>4.0.4</Version>
   <Description>Run your typical ObjectScript %UnitTest tests and see which lines of your code are executed. Includes Cobertura-style reporting for use in continuous integration tools.</Description>
   <Packaging>module</Packaging>
   <Resource Name="TestCoverage.PKG" Directory="cls" />