Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissing Lite Terminal connection picker using Esc still gives misleading message #1472

Open
gjsjohnmurray opened this issue Jan 31, 2025 · 0 comments · May be fixed by #1473
Open

Dismissing Lite Terminal connection picker using Esc still gives misleading message #1472

gjsjohnmurray opened this issue Jan 31, 2025 · 0 comments · May be fixed by #1473
Assignees

Comments

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Jan 31, 2025

Nice. Just one observation from my testing so far. When I have a workspace with at least 2 folders with distinct connections to 2023.2+ servers, and I invoke Lite Terminal from the dropdown on Panel's Terminal view, I correctly get the new picker. But if I change my mind and dismiss it with Esc I get an error notification on the bottom right saying "Lite Terminal requires an active server connection to InterSystems IRIS version 2023.2 or above.". It'd be nicer to suppress that in this case, but still present it if there were no eligible connections to offer the user. I guess that'd require getWsServerConnection to give different responses in those two cases rather than undefined for both.

Originally posted by @gjsjohnmurray in #1467 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant