Show objectscript.conn.docker-compose type connections under 'Current' node
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the way this looks! I'll approve once the corresponding vscode-objectscript PR is approved and merged. |
|
@isc-bsaviano and @isc-rsingh please try installing the VSIXes from both PRs to validate them. |
|
will try it out this weekend.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #187
For example:
This workspace consists of 2 local folders. Each contains a docker-compose.yml and a Dockerfile plus a .vscode/settings.json with an
objectscript.connreferencing the corresponding Docker service.The enhancement makes the two docker servers appear in the Current node of the tree. The (dynamic) local port for each is displayed.
Their namespaces can be browsed in Server Manager in the usual manner. Lite Terminals can be launched, and isfs or isfs-readonly folders can be added to the workspace.
This enhancement depends on a related change in the ObjectScript extension (intersystems-community/vscode-objectscript#1471)
The VSIX built from this PR should work OK with ObjectScript VSIXes that don't contain the relevant change, and vice versa. However the new features will only become available when both extensions have been updated.