Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #3

Closed
Umaaz opened this issue May 17, 2023 — with Slack · 2 comments
Closed

Feedback #3

Umaaz opened this issue May 17, 2023 — with Slack · 2 comments
Assignees

Comments

Copy link
Member

Umaaz commented May 17, 2023

Things I’ve found so far:

  1. The service doesn’t seem to be listed
  2. No snapshots seem to return if the tp tag is filled in the Search
  3. I put tracepoints in on 2 different paths (/src/python/… and /simple-app/… ) but tracepoints seem to fire for both, not sure if this is an issue or just both are available - i seem to get a mix of snapshots for both
  4. The delete tracepoint probably should just delete it without opening the second Explore pane - took me a while to connect with the need to push the Delete Tracepoint in the other pane
  5. Sometime when you click List Tracepoints or Create Tracepoint it doesn’t clear the screen below so you have a list of snapshots which can be a bit confusing until you push the refresh button
  6. It would be really great to edit or somehow reactive an tracepoint
  7. Somehow the firecount control when into autodrive and did a large -ve number
  8. I think that if firecount is blank then it should be always fire (with the text saying either always or unlimited or something). I tried to enter -1 by typing it in and I couldn’t do it and it seems a little odd to have -1
  9. The tags seems to have some auto complete support for telemetry.* data but not tp (which maybe should be called tracepoint)
  10. It will be amazing to generate a metric from a tracepoint so that we could see that metrics and leave it running when we want insight into a program
  11. It would also be amazing to have this wired into the alerting engine so that when a snapshot variable or watchpoint I guess could trigger an alert
  12. I’m also really looking forwards to dynamic log
    This is really brilliant!

Slack Message

@Umaaz
Copy link
Member Author

Umaaz commented Feb 14, 2024

  1. This appears to be an issue in the deep service service.name values are not returned deep#80
  2. This was due to the tag being renamed to 'tracepoint'
  3. This is due to the way python matches files and is not a bug
  4. This is a limit of explore which I will look at again.
  5. This is a limit of explore which I will look at again.
  6. rearm is going to be an issue with the fire count being local. The fire count feature will need a review of how this would work. Feature: global fire count control deep#81
  7. Improvements have been made in feat(create): add support for creating tracepoints with span and metrics #34
  8. Improvements have been made in feat(create): add support for creating tracepoints with span and metrics #34
  9. The auto complete is for 'resource' labels only not for snapshot attributes.
  10. see feat(create): add support for creating tracepoints with span and metrics #34
  11. issue created Feature: alerts deep#82
  12. complete.

@Umaaz Umaaz closed this as completed Feb 14, 2024
@Umaaz Umaaz self-assigned this Feb 14, 2024
@Umaaz
Copy link
Member Author

Umaaz commented Feb 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant