Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include Document if not needed #73

Open
cjimmy opened this issue Mar 24, 2021 · 2 comments
Open

Don't include Document if not needed #73

cjimmy opened this issue Mar 24, 2021 · 2 comments

Comments

@cjimmy
Copy link

cjimmy commented Mar 24, 2021

The codegen'd file included

import {Document} from '@contentful/rich-text-types'

even though none of my types needed it. In order to avoid TS errors without manual intervention (or a hack-y script to modify the file), I have to include the package @contentful/rich-text-types. Ideally, it would not automatically assume our schema includes RichText.

@agrumason
Copy link

I have noticed that too, would be great having types without unused import.

@mikelehen
Copy link

+1. This is causing eslint to fail on the file for our project due to the unused import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants