-
Notifications
You must be signed in to change notification settings - Fork 68
Gemm Universal unit tests for MainloopIntelW8A8 API #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive unit test coverage for Intel Xe FP8 GEMM operations using the MainloopIntelW8A8 dispatch policy. The tests validate FP8→FP32 matrix multiplication across diverse workload scenarios including LLM model configurations (LLaMA2-7B, Mistral-7B), various parallelization strategies, different batch sizes, and edge cases with large matrix dimensions.
Key Changes:
- Added 14 test cases covering LLM workloads, parallelization patterns, batch processing, and matrix shape variations
- Extended
TestXehelper function to support 4D problem shapes (MNKL) for batched GEMM operations - Integrated new test file into CMake build system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gemm_universal_fp8_fp8_fp32_tensor_op_f32_xe_models.cpp | New test file with 14 unit tests for MainloopIntelW8A8 covering LLM models, parallelization, batching, and edge cases |
| gemm_testbed_3x.hpp | Added overloaded TestXe function to support batched GEMM testing with 4D problem shapes |
| CMakeLists.txt | Registered new test file in SYCL build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | ||
| throw; | ||
| } | ||
| catch (...) { | ||
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception for MNKL = " |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using EXPECT_TRUE(false) is unconventional. Consider using ADD_FAILURE() or FAIL() instead for clearer test failure reporting.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception for MNKL = " | |
| ADD_FAILURE() << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| ADD_FAILURE() << "TestXe: testbed.run threw an unknown exception for MNKL = " |
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | ||
| throw; | ||
| } | ||
| catch (...) { | ||
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception for MNKL = " |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using EXPECT_TRUE(false) is unconventional. Consider using ADD_FAILURE() or FAIL() instead for clearer test failure reporting.
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| EXPECT_TRUE(false) << "TestXe: testbed.run threw an unknown exception for MNKL = " | |
| ADD_FAILURE() << "TestXe: testbed.run threw an exception: " << e.what(); | |
| throw; | |
| } | |
| catch (...) { | |
| ADD_FAILURE() << "TestXe: testbed.run threw an unknown exception for MNKL = " |
Unit tests for MainloopIntelW8A8 FP8 GEMM operations on Intel Xe
Comprehensive test coverage for Intel GPU FP8 GEMM kernels including:
Tests validate
MainloopIntelW8A8dispatch policy with FP8→FP32 precision on Intel Xe XMX architecture.