Use auto to improve readability

Using : -checks=modernize-use-auto

Signed-off-by: Florian Poncabaré <[email protected]>

Author: Florian Poncabaré

bindings/c/ParameterFramework.cpp

@@ -249,7 +249,7 @@ const char *pfwGetLastError(const PfwHandler *handle)
 
 static pfw::Criterion *getCriterion(const pfw::Criteria &criteria, const string &name)
 {
-    pfw::Criteria::const_iterator it = criteria.find(name);
+    auto it = criteria.find(name);
     return it == criteria.end() ? nullptr : it->second;
 }
 

parameter/ConfigurableDomain.cpp

@@ -627,7 +627,7 @@ bool CConfigurableDomain::createConfiguration(const string &strName,
     }
 
     // Creation
-    CDomainConfiguration *pDomainConfiguration = new CDomainConfiguration(strName);
+    auto pDomainConfiguration = new CDomainConfiguration(strName);
 
     // Configurable elements association
     ConfigurableElementListIterator it;
@@ -1106,7 +1106,7 @@ void CConfigurableDomain::doAddConfigurableElement(CConfigurableElement *pConfig
     pConfigurableElement->addAttachedConfigurableDomain(this);
 
     // Create associated syncer set
-    CSyncerSet *pSyncerSet = new CSyncerSet;
+    auto pSyncerSet = new CSyncerSet;
 
     // Add to sync set the configurable element one
     pConfigurableElement->fillSyncerSet(*pSyncerSet);
@@ -1182,8 +1182,7 @@ void CConfigurableDomain::doRemoveConfigurableElement(CConfigurableElement *pCon
 CSyncerSet *CConfigurableDomain::getSyncerSet(
     const CConfigurableElement *pConfigurableElement) const
 {
-    ConfigurableElementToSyncerSetMapIterator mapIt =
-        _configurableElementToSyncerSetMap.find(pConfigurableElement);
+    auto mapIt = _configurableElementToSyncerSetMap.find(pConfigurableElement);
 
     ALWAYS_ASSERT(mapIt != _configurableElementToSyncerSetMap.end(),
                   "Could not find syncer set for " << getName() << " configurable domain");

parameter/ElementLibrary.cpp

@@ -48,7 +48,7 @@ void CElementLibrary::clean()
 
 CElement *CElementLibrary::createElement(const CXmlElement &xmlElement) const
 {
-    ElementBuilderMapConstIterator it = _elementBuilderMap.find(getBuilderType(xmlElement));
+    auto it = _elementBuilderMap.find(getBuilderType(xmlElement));
 
     if (it != _elementBuilderMap.end()) {
 

parameter/MappingData.cpp

@@ -73,7 +73,7 @@ bool CMappingData::init(const std::string &rawMapping, std::string &error)
 
 bool CMappingData::getValue(const std::string &strkey, const std::string *&pStrValue) const
 {
-    KeyToValueMapConstIterator it = _keyToValueMap.find(strkey);
+    auto it = _keyToValueMap.find(strkey);
 
     if (it != _keyToValueMap.end()) {
 

parameter/ParameterMgr.cpp

@@ -2738,7 +2738,7 @@ CParameterBlackboard *CParameterMgr::getParameterBlackboard()
 void CParameterMgr::feedElementLibraries()
 {
     // Global Configuration handling
-    CElementLibrary *pFrameworkConfigurationLibrary = new CElementLibrary;
+    auto pFrameworkConfigurationLibrary = new CElementLibrary;
 
     pFrameworkConfigurationLibrary->addElementBuilder(
         "ParameterFrameworkConfiguration",
@@ -2759,7 +2759,7 @@ void CParameterMgr::feedElementLibraries()
     _pElementLibrarySet->addElementLibrary(pFrameworkConfigurationLibrary);
 
     // Parameter creation
-    CElementLibrary *pParameterCreationLibrary = new CElementLibrary;
+    auto pParameterCreationLibrary = new CElementLibrary;
 
     pParameterCreationLibrary->addElementBuilder(
         "Subsystem", new CSubsystemElementBuilder(getSystemClass()->getSubsystemLibrary()));
@@ -2798,7 +2798,7 @@ void CParameterMgr::feedElementLibraries()
     _pElementLibrarySet->addElementLibrary(pParameterCreationLibrary);
 
     // Parameter Configuration Domains creation
-    CElementLibrary *pParameterConfigurationLibrary = new CElementLibrary;
+    auto pParameterConfigurationLibrary = new CElementLibrary;
 
     pParameterConfigurationLibrary->addElementBuilder(
         "ConfigurableDomain", new TElementBuilderTemplate<CConfigurableDomain>());

parameter/RuleParser.cpp

@@ -70,7 +70,7 @@ bool CRuleParser::parse(CCompoundRule *pParentRule, string &strError)
         case EBeginCompoundRule: {
 
             // Create new compound rule
-            CCompoundRule *pCompoundRule = new CCompoundRule;
+            auto pCompoundRule = new CCompoundRule;
 
             // Parse
             if (!pCompoundRule->parse(*this, strError)) {
@@ -104,7 +104,7 @@ bool CRuleParser::parse(CCompoundRule *pParentRule, string &strError)
             break;
         case ECriterionRule: {
             // Create new criterion rule
-            CSelectionCriterionRule *pCriterionRule = new CSelectionCriterionRule;
+            auto pCriterionRule = new CSelectionCriterionRule;
 
             // Parse
             if (!pCriterionRule->parse(*this, strError)) {

parameter/SelectionCriteriaDefinition.cpp

@@ -39,7 +39,7 @@ std::string CSelectionCriteriaDefinition::getKind() const
 CSelectionCriterion *CSelectionCriteriaDefinition::createSelectionCriterion(
     const std::string &strName, const CSelectionCriterionType *pType, core::log::Logger &logger)
 {
-    CSelectionCriterion *pSelectionCriterion = new CSelectionCriterion(strName, pType, logger);
+    auto pSelectionCriterion = new CSelectionCriterion(strName, pType, logger);
 
     addChild(pSelectionCriterion);
 

parameter/SelectionCriterionLibrary.cpp

@@ -39,7 +39,7 @@ std::string CSelectionCriterionLibrary::getKind() const
 // Type creation
 CSelectionCriterionType *CSelectionCriterionLibrary::createSelectionCriterionType(bool bIsInclusive)
 {
-    CSelectionCriterionType *pSelectionCriterionType = new CSelectionCriterionType(bIsInclusive);
+    auto pSelectionCriterionType = new CSelectionCriterionType(bIsInclusive);
 
     addChild(pSelectionCriterionType);
 

parameter/SelectionCriterionType.cpp

@@ -118,7 +118,7 @@ bool CSelectionCriterionType::getNumericalValue(const std::string &strValue, int
 bool CSelectionCriterionType::getAtomicNumericalValue(const std::string &strValue,
                                                       int &iValue) const
 {
-    NumToLitMapConstIt it = _numToLitMap.find(strValue);
+    auto it = _numToLitMap.find(strValue);
 
     if (it != _numToLitMap.end()) {
 

parameter/SystemClass.cpp

@@ -182,7 +182,7 @@ bool CSystemClass::loadPlugins(list<string> &lstrPluginFiles, core::Results &err
 
     bool bAtLeastOneSubsystemPluginSuccessfullyLoaded = false;
 
-    list<string>::iterator it = lstrPluginFiles.begin();
+    auto it = lstrPluginFiles.begin();
 
     while (it != lstrPluginFiles.end()) {