File tree Expand file tree Collapse file tree 1 file changed +10
-9
lines changed Expand file tree Collapse file tree 1 file changed +10
-9
lines changed Original file line number Diff line number Diff line change @@ -701,8 +701,6 @@ if ( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )
701
701
append ("${module_flags} " CMAKE_CXX_FLAGS )
702
702
endif ( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )
703
703
704
- option (LLVM_ENABLE_WARNINGS_FOR_PASS_BINSKIM "Enable compiler warnings for pass binskim." OFF )
705
-
706
704
if (MSVC )
707
705
if (NOT CLANG_CL )
708
706
set (msvc_warning_flags
@@ -765,15 +763,18 @@ if (MSVC)
765
763
)
766
764
endif (NOT CLANG_CL )
767
765
768
- # Remove -wd4146 -wd4244 -wd4267 to pass Binskim
769
- if (LLVM_ENABLE_WARNINGS_FOR_PASS_BINSKIM )
770
- string (REPLACE "-wd4146" "" msvc_warning_flags "${msvc_warning_flags} " )
771
- string (REPLACE "-wd4244" "" msvc_warning_flags "${msvc_warning_flags} " )
772
- string (REPLACE "-wd4267" "" msvc_warning_flags "${msvc_warning_flags} " )
773
- endif ()
774
-
775
766
# Enable warnings
776
767
if (LLVM_ENABLE_WARNINGS )
768
+ # Remove all -wd flag to enable warnings
769
+ if (NOT CLANG_CL )
770
+ set (msvc_warning_flags
771
+ # Promoted warnings.
772
+ -w14062 # Promote 'enumerator in switch of enum is not handled' to level 1 warning.
773
+
774
+ # Promoted warnings to errors.
775
+ -we4238 # Promote 'nonstandard extension used : class rvalue used as lvalue' to error.
776
+ )
777
+ endif (NOT CLANG_CL )
777
778
# Put /W4 in front of all the -we flags. cl.exe doesn't care, but for
778
779
# clang-cl having /W4 after the -we flags will re-enable the warnings
779
780
# disabled by -we.
You can’t perform that action at this time.
0 commit comments