Skip to content

[UR] Update SetErrorMessage implementations to have correct type for ErrorCode param #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martygrant opened this issue Apr 30, 2025 · 0 comments · May be fixed by #18264
Open

[UR] Update SetErrorMessage implementations to have correct type for ErrorCode param #18260

martygrant opened this issue Apr 30, 2025 · 0 comments · May be fixed by #18264
Assignees
@martygrant
Labels
unified-runtime

Comments

@martygrant
Copy link
Contributor

martygrant commented Apr 30, 2025 •
edited
Loading

As discussed in #18182 (comment) the common function SetErrorMessage which is used to set the message retrieved when using the urAdapterGetLastError entry point is expecting a ur_result_t for the ErrorCode param but should instead be int32_t, this occurs in most adapter implementations.
@martygrant martygrant self-assigned this Apr 30, 2025
@martygrant martygrant mentioned this issue Apr 30, 2025
Open
@martygrant martygrant changed the title [UR] Update urAdapterGetLastError implementations to have correct type for pError param [UR] Update SetErrorMessage implementations to have correct type for pError param Apr 30, 2025
@martygrant martygrant changed the title [UR] Update SetErrorMessage implementations to have correct type for pError param [UR] Update SetErrorMessage implementations to have correct type for ErrorCode param Apr 30, 2025
@martygrant martygrant linked a pull request Apr 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martygrant martygrant

Labels
unified-runtime
Projects
None yet
Milestone
No milestone
2 participants
@martygrant @0x12CC