Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the latency of pulldown from sycl branch to sycl-mlir branch #12047

Open
keryell opened this issue Nov 30, 2023 · 4 comments
Open

Decrease the latency of pulldown from sycl branch to sycl-mlir branch #12047

keryell opened this issue Nov 30, 2023 · 4 comments
Assignees
Labels
sycl-mlir Pull requests or issues for sycl-mlir branch

Comments

@keryell
Copy link
Contributor

keryell commented Nov 30, 2023

There is currently a pulldown of upstream LLVM into sycl branch around twice a week, which is great.
Unfortunately, the pulldown from the sycl branch into sycl-mlir happens quite less often.
This makes difficult the mix-and-match of this project with other MLIR projects.

@bader bader added the sycl-mlir Pull requests or issues for sycl-mlir branch label Nov 30, 2023
@victor-eds
Copy link
Contributor

Keeping the branch up-to-date can a bit time-consuming. As priority for this has changed in the past few weeks, we have been a bit laggy in this process. However, we have included instructions to pulldown from sycl in #12050. We'll be happily providing quick reviews to rebase PRs.

@sommerlukas
Copy link
Contributor

Hi @keryell,

thanks for your interest in the project!

There is a bot to automate the pulldown from sycl to sycl-mlir, which works fine as long as there are no merge conflicts.

If there is a merge conflict, these need to be resolved manually, which we currently do on a best-effort basis.

If you have a specific MLIR/LLVM feature that you need in a short timeframe, you can follow the instructions in #12050 for the pulldown. We are happy to review PRs for pulldowns.

With the typed pointer support now (virtually) removed from upstream MLIR, we hope that we will encounter merge conflicts less frequently as soon as we have removed the last remainders of that API (we have already switched to opaque pointers a while ago) and the automatic bot would lead to a decreased latency.

@keryell
Copy link
Contributor Author

keryell commented Dec 6, 2023

Thank you for updating the documentation. If you are motivated, updating the top-level README of this MLIR project could be useful for the future generations. :-)
I am struggling just to have the baseline of the tests passing.
#12087
#12090
#12091

@victor-eds
Copy link
Contributor

If you are motivated, updating the top-level README of this MLIR project could be useful for the future generations. :-)

Yes, maybe having some kind of pointer to the SYCL-MLIR README would be a good step forward. Thanks, @keryell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Development

No branches or pull requests

5 participants