Skip to content

Commit d877bb9

Browse files
[UR] Bump UMF to v0.12.0-dev2-6 (#18378)
1 parent 4098f4d commit d877bb9

File tree

6 files changed

+25
-20
lines changed

6 files changed

+25
-20
lines changed

unified-runtime/source/adapters/hip/usm.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,8 @@ void USMMemoryProvider::get_last_native_error(const char **ErrMsg,
322322
*ErrCode = static_cast<int32_t>(getLastStatusRef());
323323
}
324324

325-
umf_result_t USMMemoryProvider::get_min_page_size(void *Ptr, size_t *PageSize) {
325+
umf_result_t USMMemoryProvider::get_min_page_size(const void *Ptr,
326+
size_t *PageSize) {
326327
(void)Ptr;
327328
*PageSize = MinPageSize;
328329

unified-runtime/source/adapters/hip/usm.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class USMMemoryProvider {
6262
umf_result_t alloc(size_t Size, size_t Align, void **Ptr);
6363
umf_result_t free(void *Ptr, size_t Size);
6464
void get_last_native_error(const char **ErrMsg, int32_t *ErrCode);
65-
umf_result_t get_min_page_size(void *, size_t *);
65+
umf_result_t get_min_page_size(const void *, size_t *);
6666
umf_result_t get_recommended_page_size(size_t, size_t *) {
6767
return UMF_RESULT_ERROR_NOT_SUPPORTED;
6868
};

unified-runtime/source/adapters/level_zero/usm.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -730,9 +730,10 @@ enum umf_result_t L0MemoryProvider::free(void *Ptr, size_t Size) {
730730
return UMF_RESULT_SUCCESS;
731731
}
732732

733-
umf_result_t L0MemoryProvider::GetL0MinPageSize(void *Mem, size_t *PageSize) {
733+
umf_result_t L0MemoryProvider::GetL0MinPageSize(const void *Mem,
734+
size_t *PageSize) {
734735
ur_result_t Res = UR_RESULT_SUCCESS;
735-
void *Ptr = Mem;
736+
void *Ptr = const_cast<void *>(Mem);
736737

737738
if (!Mem) {
738739
Res = allocateImpl(&Ptr, 1, 0);
@@ -765,7 +766,8 @@ umf_result_t L0MemoryProvider::GetL0MinPageSize(void *Mem, size_t *PageSize) {
765766
return UMF_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC;
766767
}
767768

768-
umf_result_t L0MemoryProvider::get_min_page_size(void *Ptr, size_t *PageSize) {
769+
umf_result_t L0MemoryProvider::get_min_page_size(const void *Ptr,
770+
size_t *PageSize) {
769771

770772
// Query L0 for min page size. Use provided 'Ptr'.
771773
if (Ptr) {

unified-runtime/source/adapters/level_zero/usm.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class USMMemoryProviderBase {
9292
virtual umf_result_t free(void *, size_t) {
9393
return UMF_RESULT_ERROR_NOT_SUPPORTED;
9494
};
95-
virtual umf_result_t get_min_page_size(void *, size_t *) {
95+
virtual umf_result_t get_min_page_size(const void *, size_t *) {
9696
return UMF_RESULT_ERROR_NOT_SUPPORTED;
9797
};
9898
virtual umf_result_t get_recommended_page_size(size_t, size_t *) {
@@ -133,7 +133,7 @@ class USMMemoryProviderBase {
133133
class L0MemoryProvider : public USMMemoryProviderBase {
134134
private:
135135
// Min page size query function for L0MemoryProvider.
136-
umf_result_t GetL0MinPageSize(void *Mem, size_t *PageSize);
136+
umf_result_t GetL0MinPageSize(const void *Mem, size_t *PageSize);
137137
size_t MinPageSize = 0;
138138
bool MinPageSizeCached = false;
139139

@@ -142,7 +142,7 @@ class L0MemoryProvider : public USMMemoryProviderBase {
142142
ur_device_handle_t Dev) override;
143143
umf_result_t alloc(size_t Size, size_t Align, void **Ptr) override;
144144
umf_result_t free(void *Ptr, size_t Size) override;
145-
umf_result_t get_min_page_size(void *, size_t *) override;
145+
umf_result_t get_min_page_size(const void *, size_t *) override;
146146
// TODO: Different name for each provider (Host/Shared/SharedRO/Device)
147147
const char *get_name() override { return "Level Zero"; };
148148
umf_result_t get_ipc_handle_size(size_t *) override;

unified-runtime/source/common/CMakeLists.txt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ if (NOT DEFINED UMF_REPO)
4040
endif()
4141

4242
if (NOT DEFINED UMF_TAG)
43-
# commit a5c3d266641c479511dc6a984ea5b71257e8fee9
44-
# Author: Łukasz Stolarczuk <[email protected]>
45-
# Date: Thu Apr 17 14:13:05 2025 +0200
46-
# 0.11.0 release
47-
set(UMF_TAG v0.11.0)
43+
# commit 0a63bbd489e8e910c3f9a2129b287bfc63925716 (HEAD -> main, upstream/main)
44+
# Author: Rafał Rudnicki <[email protected]>
45+
# Date: Mon May 12 09:46:48 2025 +0200
46+
# Merge pull request #1308 from lukaszstolarczuk/depr-hwloc-disable-cmake
47+
# [CMake] Warn about UMF_DISABLE_HWLOC being deprecated
48+
set(UMF_TAG 0a63bbd489e8e910c3f9a2129b287bfc63925716)
4849
endif()
4950

5051
message(STATUS "Will fetch Unified Memory Framework from ${UMF_REPO}")

unified-runtime/source/common/umf_helpers.hpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ umf_memory_pool_ops_t poolMakeUniqueOps() {
130130
umf_memory_pool_ops_t ops = {};
131131

132132
ops.version = UMF_VERSION_CURRENT;
133-
ops.initialize = [](umf_memory_provider_handle_t provider, void *params,
133+
ops.initialize = [](umf_memory_provider_handle_t provider, const void *params,
134134
void **obj) {
135135
try {
136136
*obj = new T;
@@ -168,7 +168,7 @@ auto memoryProviderMakeUnique(Args &&...args) {
168168
auto argsTuple = std::make_tuple(std::forward<Args>(args)...);
169169

170170
ops.version = UMF_VERSION_CURRENT;
171-
ops.initialize = [](void *params, void **obj) {
171+
ops.initialize = [](const void *params, void **obj) {
172172
try {
173173
*obj = new T;
174174
} catch (...) {
@@ -177,7 +177,7 @@ auto memoryProviderMakeUnique(Args &&...args) {
177177

178178
return detail::initialize<T>(
179179
reinterpret_cast<T *>(*obj),
180-
*reinterpret_cast<decltype(argsTuple) *>(params));
180+
*reinterpret_cast<decltype(argsTuple) *>(const_cast<void *>(params)));
181181
};
182182
ops.finalize = [](void *obj) { delete reinterpret_cast<T *>(obj); };
183183

@@ -222,7 +222,7 @@ auto poolMakeUnique(provider_unique_handle_t provider, Args &&...args) {
222222
ret, pool_unique_handle_t(hPool, umfPoolDestroy)};
223223
}
224224

225-
static inline auto poolMakeUniqueFromOps(umf_memory_pool_ops_t *ops,
225+
static inline auto poolMakeUniqueFromOps(const umf_memory_pool_ops_t *ops,
226226
provider_unique_handle_t provider,
227227
void *params) {
228228
umf_memory_pool_handle_t hPool;
@@ -240,7 +240,7 @@ static inline auto poolMakeUniqueFromOps(umf_memory_pool_ops_t *ops,
240240
}
241241

242242
static inline auto
243-
poolMakeUniqueFromOpsProviderHandle(umf_memory_pool_ops_t *ops,
243+
poolMakeUniqueFromOpsProviderHandle(const umf_memory_pool_ops_t *ops,
244244
umf_memory_provider_handle_t provider,
245245
void *params) {
246246
umf_memory_pool_handle_t hPool;
@@ -254,8 +254,9 @@ poolMakeUniqueFromOpsProviderHandle(umf_memory_pool_ops_t *ops,
254254
UMF_RESULT_SUCCESS, pool_unique_handle_t(hPool, umfPoolDestroy)};
255255
}
256256

257-
static inline auto providerMakeUniqueFromOps(umf_memory_provider_ops_t *ops,
258-
void *params) {
257+
static inline auto
258+
providerMakeUniqueFromOps(const umf_memory_provider_ops_t *ops,
259+
const void *params) {
259260
umf_memory_provider_handle_t hProvider;
260261
auto ret = umfMemoryProviderCreate(ops, params, &hProvider);
261262
if (ret != UMF_RESULT_SUCCESS) {

0 commit comments

Comments
 (0)