Skip to content

Commit af21872

Browse files
committed
test
Signed-off-by: Sarnie, Nick <[email protected]>
1 parent 0666559 commit af21872

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

Diff for: clang/lib/Sema/SemaDeclAttr.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -5574,7 +5574,7 @@ bool Sema::CheckCallingConvAttr(const ParsedAttr &Attrs, CallingConv &CC,
55745574
A = HostTI->checkCallingConvention(CC);
55755575
if (A == TargetInfo::CCCR_OK && CheckDevice && DeviceTI)
55765576
A = DeviceTI->checkCallingConvention(CC);
5577-
} else if (LangOpts.SYCLIsDevice && Aux->getTriple().isOSWindows() &&
5577+
} else if (LangOpts.SYCLIsDevice && (Aux && Aux->getTriple().isOSWindows()) &&
55785578
TI.getTriple().isAMDGPU() &&
55795579
getSourceManager().isInSystemHeader(Attrs.getScopeLoc())) {
55805580
A = TI.checkCallingConvention(CC);

Diff for: sycl/test-e2e/E2EExpr.py

+2
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ class E2EExpr(BooleanExpression):
3333
"hip_dev_kit",
3434
"zstd",
3535
"vulkan",
36+
"hip_options"
37+
"cuda_options"
3638
"true",
3739
"false",
3840
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// REQUIRES: hip_dev_kit
22

3-
// RUN: %clangxx -fsycl -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1030 --rocm-path="C:/Program Files/AMD/ROCm/6.2/" %S/Inputs/is_compatible_with_env.cpp -o %t.out
3+
// RUN: %clangxx %hip_options -fsycl -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1030 %S/Inputs/is_compatible_with_env.cpp -o %t.out
44

55
// RUN: %if !hip %{ not %} %{run} %t.out
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
// REQUIRES: cuda_dev_kit
22

3-
// UNSUPPORTED: windows
4-
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17515
5-
// CUDA libs are not installed correctly.
6-
7-
// RUN: %clangxx -fsycl -fsycl-targets=nvptx64-nvidia-cuda %S/Inputs/is_compatible_with_env.cpp -o %t.out
3+
// RUN: %clangxx %cuda_options -fsycl -fsycl-targets=nvptx64-nvidia-cuda %S/Inputs/is_compatible_with_env.cpp -o %t.out
84

95
// RUN: %if !cuda %{ not %} %{run} %t.out

Diff for: sycl/test-e2e/lit.cfg.py

+8
Original file line numberDiff line numberDiff line change
@@ -437,13 +437,17 @@ def open_check_file(file_name):
437437
+ " -lcuda "
438438
+ " -I"
439439
+ config.cuda_include
440+
+ " --cuda-path="
441+
+ os.path.dirname(config.cuda_libs_dir)
440442
)
441443
if cl_options:
442444
cuda_options = (
443445
" "
444446
+ (config.cuda_libs_dir + "/cuda.lib " if config.cuda_libs_dir else "cuda.lib")
445447
+ " /I"
446448
+ config.cuda_include
449+
+ " --cuda-path="
450+
+ os.path.dirname(config.cuda_libs_dir)
447451
)
448452

449453
config.substitutions.append(("%cuda_options", cuda_options))
@@ -486,6 +490,8 @@ def open_check_file(file_name):
486490
+ " -lamdhip64 "
487491
+ " -I"
488492
+ config.hip_include
493+
+ " --rocm-path=" +
494+
os.path.dirname(config.hip_libs_dir)
489495
)
490496
if cl_options:
491497
hip_options = (
@@ -497,6 +503,8 @@ def open_check_file(file_name):
497503
)
498504
+ " /I"
499505
+ config.hip_include
506+
+ " --rocm-path=" +
507+
os.path.dirname(config.hip_libs_dir)
500508
)
501509

502510
with test_env():

0 commit comments

Comments
 (0)