Skip to content

Commit 781b00c

Browse files
authored
[SYCL][E2E] Fix two Windows ocloc tests (#14560)
I recently found out ocloc tests weren't running in Windows CI because the ocloc tool wasn't installed on the runners. When trying to fix it, I [hit](https://github.com/intel/llvm/actions/runs/9909706895/job/27379893885?pr=14114) two failures that would have always failed if we were testing (the other two are going to be fixed [here](#14556)). The first fix disables the test on Windows because it is using `pvc` which is not available on Windows. The seconds add a requirement for the OCL CPU driver to be installed because the test is using `ocloc-aot`, as per the [ocloc-aot doc](https://github.com/intel/llvm/blob/56e88d591c52a978abdd5e4279853311cae4a55e/opencl/opencl-aot/README.md?plain=1#L11). The CI testing in this PR is only confirming I didn't break the tests on non-win ocloc because I haven't enabled Windows ocloc testing yet, but I manually verified the fix. --------- Signed-off-by: Sarnie, Nick <[email protected]>
1 parent d2f6fb3 commit 781b00c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
// REQUIRES: ocloc, gpu
1+
// REQUIRES: ocloc, gpu, linux
22
// UNSUPPORTED: cuda, hip
33

4-
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device pvc" -fsycl-fp64-conv-emu %if system-windows %{ -Od %} %else %{ -O0 %} %s -o %t_opt.out
4+
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device pvc" -fsycl-fp64-conv-emu -O0 %s -o %t_opt.out
55
// TODO: Enable when GPU driver is updated.
66
// RUNx: %{run} %t_opt.out
77

sycl/test-e2e/ProgramManager/uneven_kernel_split.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// REQUIRES: gpu, opencl-aot, ocloc
1+
// REQUIRES: any-device-is-cpu, gpu, opencl-aot, ocloc
22
// UNSUPPORTED: cuda, hip
33

44
// RUN: %clangxx -fsycl -fsycl-targets=spir64_x86_64 -I %S/Inputs/ %S/uneven_kernel_split.cpp -c -o %t.o

0 commit comments

Comments
 (0)