[SYCL] Propagate data from handler to DeviceKernelInfo when using old binaries (#19993)

`DeviceKernelInfoPtr` wasn't/isn't used a single source of information
neither before not after this PR, so things weren't "broken". However,
we want to change that soon and for that we need all the necessary
information from `handler`/`handler_impl` to be available in
`DeviceKernelInfoPtr`. That change brings us closer to that state.

Author: aelovikov-intel

sycl/source/detail/device_kernel_info.cpp

@@ -32,9 +32,13 @@ void DeviceKernelInfo::init(KernelNameStrRefT KernelName) {
 }
 
 #ifndef __INTEL_PREVIEW_BREAKING_CHANGES
-void DeviceKernelInfo::initIfNeeded(KernelNameStrRefT KernelName) {
-  if (!MInitialized.load())
-    init(KernelName);
+void DeviceKernelInfo::initIfEmpty(const CompileTimeKernelInfoTy &Info) {
+  if (MInitialized.load())
+    return;
+
+  CompileTimeKernelInfoTy::operator=(Info);
+  Name = Info.Name.data();
+  init(Name.data());
 }
 #endif
 

sycl/source/detail/device_kernel_info.hpp

@@ -102,7 +102,8 @@ class DeviceKernelInfo : public CompileTimeKernelInfoTy {
 
   void init(KernelNameStrRefT KernelName);
 #ifndef __INTEL_PREVIEW_BREAKING_CHANGES
-  void initIfNeeded(KernelNameStrRefT KernelName);
+  // Initialize default-created entry that has no data recorded:
+  void initIfEmpty(const CompileTimeKernelInfoTy &Info);
 #endif
   void setCompileTimeInfoIfNeeded(const CompileTimeKernelInfoTy &Info);
 

sycl/source/handler.cpp

@@ -544,7 +544,14 @@ event handler::finalize() {
   if (type == detail::CGType::Kernel) {
     if (impl->MDeviceKernelInfoPtr) {
 #ifndef __INTEL_PREVIEW_BREAKING_CHANGES
-      impl->MDeviceKernelInfoPtr->initIfNeeded(toKernelNameStrT(MKernelName));
+      detail::CompileTimeKernelInfoTy HandlerInfo;
+      HandlerInfo.Name = MKernelName;
+      HandlerInfo.NumParams = impl->MKernelNumArgs;
+      HandlerInfo.ParamDescGetter = impl->MKernelParamDescGetter;
+      HandlerInfo.IsESIMD = impl->MKernelIsESIMD;
+      HandlerInfo.HasSpecialCaptures = impl->MKernelHasSpecialCaptures;
+
+      impl->MDeviceKernelInfoPtr->initIfEmpty(HandlerInfo);
 #endif
     } else {
       // Fetch the device kernel info pointer if it hasn't been set (e.g.
@@ -553,6 +560,20 @@ event handler::finalize() {
           &detail::ProgramManager::getInstance().getOrCreateDeviceKernelInfo(
               toKernelNameStrT(MKernelName));
     }
+
+    detail::DeviceKernelInfo &Info = *impl->MDeviceKernelInfoPtr;
+    (void)Info;
+
+    // Make sure that information set by old binaries gets properly copied to
+    // the `DeviceKernelInfo` so that the rest of the code base could use it as
+    // the single source of all the data:
+    assert(MKernelName == static_cast<std::string_view>(Info.Name));
+    assert(static_cast<unsigned>(impl->MKernelNumArgs) == Info.NumParams);
+    assert(impl->MKernelParamDescGetter == Info.ParamDescGetter ||
+           impl->MKernelParamDescGetter == nullptr);
+    assert(impl->MKernelIsESIMD == Info.IsESIMD);
+    assert(impl->MKernelHasSpecialCaptures == Info.HasSpecialCaptures);
+
     // If there were uses of set_specialization_constant build the kernel_bundle
     detail::kernel_bundle_impl *KernelBundleImpPtr =
         getOrInsertHandlerKernelBundlePtr(/*Insert=*/false);