Skip to content

Commit 30fd861

Browse files
committed
[SYCL] Require building with zstd library
SYCL device image compression requires zstd. Running `clang++ -fsycl --offload-compress` with a version of the compiler compiled without zstd leads to an error. Instead of complicating the handling of device image compression to also make it optional, it's cleaner to avoid compiling without zstd library, and to make it a required dependency for SYCL. Using LLVM_ENABLE_ZSTD=FORCE_ON prevents from compiling without zstd.
1 parent 09fd1c1 commit 30fd861

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Diff for: buildbot/configure.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ def do_configure(args, passthrough_args):
6464

6565
sycl_enable_xpti_tracing = "ON"
6666
xpti_enable_werror = "OFF"
67-
llvm_enable_zstd = "ON"
6867
spirv_enable_dis = "OFF"
6968

7069
if sys.platform != "darwin":
@@ -188,7 +187,7 @@ def do_configure(args, passthrough_args):
188187
"-DLLVM_ENABLE_PROJECTS={}".format(llvm_enable_projects),
189188
"-DSYCL_BUILD_PI_HIP_PLATFORM={}".format(sycl_build_pi_hip_platform),
190189
"-DLLVM_BUILD_TOOLS=ON",
191-
"-DLLVM_ENABLE_ZSTD={}".format(llvm_enable_zstd),
190+
"-DLLVM_ENABLE_ZSTD=FORCE_ON", # Required by SYCL device image compression.
192191
"-DLLVM_USE_STATIC_ZSTD=ON",
193192
"-DSYCL_ENABLE_WERROR={}".format(sycl_werror),
194193
"-DCMAKE_INSTALL_PREFIX={}".format(install_dir),

0 commit comments

Comments
 (0)