Skip to content

Commit 2339bac

Browse files
authored
[SYCL][Graph] Refine E2E test comment (#16842)
The code comment in `Update/FreeFunctionKernels/update_with_indices_ordering.cpp` mentions that it is unknown why the execution time is slower than the equivalent `Update/update_with_indices_ordering.cpp` test without free functions. This has now been investigated in CMPLRLLVM-64841 and has found to be due to the explicit arguments in the free function signature avoiding constant folding from lambdas. Note that we want to keep these parameters as the test is stressing the case where multiple args are passed to the free function.
1 parent a6ebaa4 commit 2339bac

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

sycl/test-e2e/Graph/Update/FreeFunctionKernels/update_with_indices_ordering.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ int main() {
2121
// Use a large N to try and make the kernel slow
2222
const size_t N = 1 << 16;
2323

24-
// Reduce amount of work compared to version of test without free functions
25-
// due to CMPLRLLVM-64841
24+
// Reduce amount of work compared to version of test with lambdas,
25+
// as using explicit parameters in the free function signature results
26+
// in slower IR than is created from constant folding in the lambda.
2627
const size_t NumKernelLoops = 1;
2728
const size_t NumSubmitLoops = 1;
2829

0 commit comments

Comments
 (0)