Code Review Process

Code Review Process

1. start work on libyami by 'fork' it to your home
2. enable coding style check by: cp pre-commit .git/hooks/
   then follows by prompt.
3. commit/push to your home's repo, test it on chromeos/ubuntu
4. create 'pull requests'
5. wait for other's review
6. update your home's repo following feedbacks
   we recommend force update to avoid unnecessary commit history, your pull requests get update automatically.
7. repeat the above two steps until no disagree
8. you can integrate your patch (home repo) with the condition met:
   

• 1+ member flags ok when patches are less than 50 lines.
  
• 2+ members flag ok when patches are more than 50 lines
  
• at least one work day passed after latest patch update
  

1. integrate the patches manually (NOT the button on web page)
   

• git push git@github.com/01org/libyami.git HEAD:master
  

we do not use the 'Merge pull request' button on web page, because:

• it creates redundant commit log.
  
• it creates unclear parent-child relation between commits when two merge requests basing on unique commit id.
  

1. now, the pull request is automatically close on web page.