[Autobackout][FunctionalRegression]Revert of change: 61e417b: Allow customizing function patch names

This change is to allow the compiler to set a customized function patch names.

Author: sys-igc

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -5658,10 +5658,9 @@ void CEncoder::Compile(bool hasSymbolTable, GenXFunctionGroupAnalysis *&pFGA) {
       }
     }
 
-    if (dbgSize > 0) {
-      dbgInfo = IGC::aligned_malloc(dbgSize, sizeof(void *));
-      memcpy_s(dbgInfo, dbgSize, genxdbgInfo, dbgSize);
-    }
+    dbgInfo = IGC::aligned_malloc(dbgSize, sizeof(void *));
+
+    memcpy_s(dbgInfo, dbgSize, genxdbgInfo, dbgSize);
 
     freeBlock(genxdbgInfo);
   }

IGC/Compiler/CISACodeGen/CShader.cpp

@@ -614,13 +614,10 @@ void CShader::AllocateNOSConstants(uint &offset) {
   offset += m_State.m_NOSBufferSize;
 }
 
-CVariable *CShader::CreateFunctionSymbol(llvm::Function *pFunc, StringRef symbolName) {
+CVariable *CShader::CreateFunctionSymbol(llvm::Function *pFunc) {
   // Functions with uses in this module requires relocation
   CVariable *funcAddr = GetSymbol(pFunc);
   std::string funcName = pFunc->getName().str();
-  if (!symbolName.empty()) {
-    funcName = symbolName.str();
-  }
   encoder.AddVISASymbol(funcName, funcAddr);
   encoder.Push();
 

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

@@ -8991,9 +8991,9 @@ void EmitPass::EmitGenIntrinsicMessage(llvm::GenIntrinsicInst *inst) {
     emitPredicatedStore(inst);
     break;
   default:
-    // we assume that some of gen-intrinsic should always be pattern-matched away,
-    // therefore we do not handle them in visa-emission.
-    // let us know if you see a case that hits this assertion by those intrinsics
+    // we assume that some of gen-intrinsic should always be pattern-matched
+    // away, therefore we do not handle them in visa-emission. let us know if
+    // you see a case that hits this assertion by those intrinsics
     inst->print(IGC::Debug::ods());
     IGC_ASSERT_MESSAGE(0, "unknown intrinsic");
     break;

IGC/Compiler/CISACodeGen/ShaderCodeGen.hpp

@@ -264,7 +264,7 @@ class CShader {
   void CreateConstantBufferOutput(SKernelProgram *pKernelProgram) {
     m_State.CreateConstantBufferOutput(pKernelProgram);
   }
-  CVariable *CreateFunctionSymbol(llvm::Function *pFunc, StringRef symbolName = "");
+  CVariable *CreateFunctionSymbol(llvm::Function *pFunc);
   CVariable *CreateGlobalSymbol(llvm::GlobalVariable *pGlobal);
 
   CVariable *GetStructVariable(llvm::Value *v);

IGC/GenISAIntrinsics/GenIntrinsicInst.h

@@ -1753,7 +1753,6 @@ class GetShaderRecordPtrIntrinsic : public GenIntrinsicInst {
   static inline bool classof(const Value *V) { return isa<GenIntrinsicInst>(V) && classof(cast<GenIntrinsicInst>(V)); }
 
   Function *getContinuationFn() const { return cast<Function>(getOperand(0)->stripPointerCasts()); }
-  uint32_t getContinuationID() const { return (uint32_t)cast<ConstantInt>(getOperand(1))->getZExtValue(); }
 };
 
 class PayloadPtrIntrinsic : public GenIntrinsicInst {

IGC/GenISAIntrinsics/generator/Intrinsic_generator.py

@@ -139,13 +139,13 @@ def get_argument_entry(cls, arg, is_last):
     @classmethod
     def get_comment(cls ,comment):
         if cls.use_comments:
-            output = '"{}"'.format(comment.strip())
+            output = '"{}"'.format(comment)
             return output
         return '""'
 
     @staticmethod
     def get_argument_comment(comment, is_last):
-        output = IntrinsicFormatter.get_comment(comment.strip())
+        output = IntrinsicFormatter.get_comment(comment)
         if not is_last:
             output = "{},".format(output)
         return output

IGC/GenISAIntrinsics/generator/input/Intrinsic_definitions.yml

@@ -11094,10 +11094,6 @@ intrinsics:
                 name: Arg0
                 type_definition: *p0_i8_
                 comment: ""
-            - !<ArgumentDefinition>
-                name: Arg1
-                type_definition: *i32
-                comment: "continuation index"
         attributes:
             - !AttributeID "NoUnwind"
             - !AttributeID "WillReturn"