Skip to content

Conversation

@traceon
Copy link

@traceon traceon commented Apr 23, 2020

  • Do not convert CMAKE_BUILD_TYPE to upper case in-place
    • Causes problems in some generators (Ninja), that construct internal target names based on this value, and sometimes, when this project is included using add_directory(), case mismatch may occur for different references to the same internal targets
    • Not a good idea to modify case in-place, it is just as unsafe as it looks...
  • Use CMAKE_CONFIGURATION_TYPES converted to upper case when deducing build type dependent vars
    • CMAKE_C_FLAGS_RelWithDebInfo is not the same as CMAKE_C_FLAGS_RELWITHDEBINFO, so addressed that too here

Use CMAKE_CONFIGURATION_TYPES converted to upper case when deducing build type dependent vars
afoxman added a commit to afoxman/hyperscan that referenced this pull request Dec 27, 2023
GerHobbelt pushed a commit to GerHobbelt/hyperscan that referenced this pull request Aug 31, 2025
Add CMake options for more build granularity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant