Enable recoverable page faults on PVC platform only

Related-To: NEO-6355

Signed-off-by: Milczarek, Slawomir <[email protected]>

Source: 9b7b193

Author: smilczar

shared/source/os_interface/hw_info_config.h

@@ -116,6 +116,7 @@ class ProductHelper {
     virtual bool is3DPipelineSelectWARequired() const = 0;
     virtual bool isStorageInfoAdjustmentRequired() const = 0;
     virtual bool isBlitterForImagesSupported() const = 0;
+    virtual bool isPageFaultSupported() const = 0;
     virtual bool isTile64With3DSurfaceOnBCSSupported(const HardwareInfo &hwInfo) const = 0;
     virtual bool isDcFlushAllowed() const = 0;
     virtual uint32_t computeMaxNeededSubSliceSpace(const HardwareInfo &hwInfo) const = 0;
@@ -272,6 +273,7 @@ class ProductHelperHw : public ProductHelper {
     bool is3DPipelineSelectWARequired() const override;
     bool isStorageInfoAdjustmentRequired() const override;
     bool isBlitterForImagesSupported() const override;
+    bool isPageFaultSupported() const override;
     bool isTile64With3DSurfaceOnBCSSupported(const HardwareInfo &hwInfo) const override;
     bool isDcFlushAllowed() const override;
     uint32_t computeMaxNeededSubSliceSpace(const HardwareInfo &hwInfo) const override;

shared/source/os_interface/hw_info_config.inl

@@ -335,6 +335,11 @@ bool ProductHelperHw<gfxProduct>::isBlitterForImagesSupported() const {
     return false;
 }
 
+template <PRODUCT_FAMILY gfxProduct>
+bool ProductHelperHw<gfxProduct>::isPageFaultSupported() const {
+    return false;
+}
+
 template <PRODUCT_FAMILY gfxProduct>
 bool ProductHelperHw<gfxProduct>::isDcFlushAllowed() const {
     return true;

shared/source/os_interface/linux/drm_neo.cpp

@@ -1168,6 +1168,10 @@ bool Drm::queryTopology(const HardwareInfo &hwInfo, QueryTopologyData &topologyD
 }
 
 void Drm::queryPageFaultSupport() {
+    const auto &productHelper = this->getRootDeviceEnvironment().getHelper<ProductHelper>();
+    if (!productHelper.isPageFaultSupported()) {
+        return;
+    }
 
     if (const auto paramId = ioctlHelper->getHasPageFaultParamId(); paramId) {
         int support = 0;

shared/source/xe_hpc_core/linux/hw_info_config_pvc.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Intel Corporation
+ * Copyright (C) 2021-2023 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -75,6 +75,11 @@ uint64_t ProductHelperHw<gfxProduct>::getDeviceMemoryMaxBandWidthInBytesPerSecon
     return memoryMaxClkRateInMhz * 1000 * 1000 * numberOfHbmStacksPerTile * memoryBusWidth / 8;
 }
 
+template <>
+bool ProductHelperHw<gfxProduct>::isPageFaultSupported() const {
+    return true;
+}
+
 } // namespace NEO
 
 #include "shared/source/xe_hpc_core/linux/hw_info_config_xe_hpc_core.inl"

shared/test/unit_test/os_interface/hw_info_config_tests.cpp

@@ -391,6 +391,11 @@ HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfBlitterForImagesIsSuppo
     EXPECT_FALSE(productHelper->isBlitterForImagesSupported());
 }
 
+HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfPageFaultIsSupportedThenReturnFalse) {
+
+    EXPECT_FALSE(productHelper->isPageFaultSupported());
+}
+
 HWTEST_F(ProductHelperTest, givenProductHelperWhenAskedIfTile64With3DSurfaceOnBCSIsSupportedThenTrueIsReturned) {
 
     EXPECT_TRUE(productHelper->isTile64With3DSurfaceOnBCSSupported(pInHwInfo));

shared/test/unit_test/os_interface/linux/drm_query_topology_prelim_tests.cpp

@@ -328,12 +328,17 @@ TEST(DrmQueryTest, WhenCallingQueryPageFaultSupportThenReturnFalseByDefault) {
 TEST(DrmQueryTest, givenPageFaultSupportEnabledWhenCallingQueryPageFaultSupportThenReturnCorrectValue) {
     auto executionEnvironment = std::make_unique<MockExecutionEnvironment>();
     DrmQueryMock drm{*executionEnvironment->rootDeviceEnvironments[0]};
+    const auto &productHelper = executionEnvironment->rootDeviceEnvironments[0]->getHelper<ProductHelper>();
 
     for (bool hasPageFaultSupport : {false, true}) {
         drm.context.hasPageFaultQueryValue = hasPageFaultSupport;
         drm.queryPageFaultSupport();
 
-        EXPECT_EQ(hasPageFaultSupport, drm.hasPageFaultSupport());
+        if (productHelper.isPageFaultSupported()) {
+            EXPECT_EQ(hasPageFaultSupport, drm.hasPageFaultSupport());
+        } else {
+            EXPECT_FALSE(drm.hasPageFaultSupport());
+        }
     }
 }
 

shared/test/unit_test/xe_hpc_core/pvc/linux/hw_info_config_tests_pvc.cpp

@@ -72,6 +72,12 @@ PVCTEST_F(PvcProductHelperLinux, givenProductHelperWhenAskedIfPatIndexProgrammin
     EXPECT_TRUE(productHelper->isVmBindPatIndexProgrammingSupported());
 }
 
+HWTEST_EXCLUDE_PRODUCT(ProductHelperTest, givenProductHelperWhenAskedIfPageFaultIsSupportedThenReturnFalse, IGFX_PVC);
+
+PVCTEST_F(PvcProductHelperLinux, givenProductHelperWhenAskedIsPageFaultSupportedThenReturnTrue) {
+    EXPECT_TRUE(productHelper->isPageFaultSupported());
+}
+
 PVCTEST_F(PvcProductHelperLinux, givenAotConfigWhenSetHwInfoRevisionIdForPvcThenCorrectValueIsSet) {
     auto &compilerProductHelper = this->executionEnvironment->rootDeviceEnvironments[0]->getHelper<CompilerProductHelper>();
     for (const auto &config : AOT_PVC::productConfigs) {

shared/test/unit_test/xe_hpg_core/mtl/linux/hw_info_config_tests_mtl.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2021-2022 Intel Corporation
+ * Copyright (C) 2021-2023 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -43,3 +43,7 @@ MTLTEST_F(MtlProductHelperLinux, givenMtlWhenIsBlitterForImagesSupportedIsCalled
 MTLTEST_F(MtlProductHelperLinux, givenMtlWhenisVmBindPatIndexProgrammingSupportedIsCalledThenTrueIsReturned) {
     EXPECT_TRUE(productHelper->isVmBindPatIndexProgrammingSupported());
 }
+
+MTLTEST_F(MtlProductHelperLinux, givenProductHelperWhenAskedIsPageFaultSupportedThenReturnFalse) {
+    EXPECT_FALSE(productHelper->isPageFaultSupported());
+}