octl tool unable to write logical groups to an empty file

[barajas]

Description:

While creating a logical group using the octl tool with a given empty file the logical group is not added.

Expected behavior:

I expect to see the logical group added on the given file and a completion message after executing it:

Grouping: Add done successfully!

Actual behavior:

I do not see the completion message and the file remains empty.

Reproduction steps:

$ touch test.xml
$ ./octl -l test.xml grouping add test1 c8

ERROR: [[INVALID],INVALID] : pugi_parser: Cannot open file 'test.xml' because No document element found
ERROR: [[61621,0],0] : pugi_parser: Cannot open file 'test.xml' because No document element found

Specifications:

• version: cad49d9
• platform: CentOS 7.2
• Component: octl tool

[ericho]

It looks like this is the suspicious code

int pugi_impl::loadFile()
{
    xml_parse_result result = doc.load_file(file.c_str(), parse_default | parse_comments);
    if (result){
        return convertXmlNodeToOpalList(doc,root);
    }
    throw unableToOpenFile(file, result.description());
}

Any error from load_file() throws a unableToOpenFile exception. This is not good, because according to pugixml documentation we are assuming that all errors are related with open file operations.