Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the functionality to set the flags via environment variables #1109

Open
tiwalter opened this issue Jul 23, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@tiwalter
Copy link

Purpose of the feature (why)

I use this addon in a Docker environment and have to adjust some settings (listen-address, etc.). Therefore, the k8s config file has to be modified. This is a manual overhead and leads to duplicate config files (one for the host and one for the Docker environment).

Your idea (how)

It would be very helpful if the user could set the flags additionally via environment variables. Libs like "viper" (https://github.com/spf13/viper) can ensure this functionality. The flags always should have higher priority than the env var, if both are set.

With this feature, you can adjust the settings without modifying the k8s config file.

@tiwalter tiwalter added the enhancement New feature or request label Jul 23, 2024
@tiwalter tiwalter changed the title Implement the functionality to set the 'get-token' flags via environment variables Implement the functionality to set the flags via environment variables Jul 23, 2024
@vrabbi
Copy link

vrabbi commented Sep 11, 2024

This would be extremely beneficial for the password grant flow as well to allow non interactive login with the user password in env vars instead of hardcoded in the kubeconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants