Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #103

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

viljarjf
Copy link
Contributor

Fix #100
Update documentation to reflect changes in #99

The mkdocs build seems correct locally.

Also adds an ignore filter to the nbcheckorder pre-commit for the single unexecuted notebook, but we could instead use the new --allow-unexecuted-notebooks flag now if we update to v0.3

I considered adding type hints toctrl in functions, but importing the TEMController also performs config setup since config is also imported. While this would probably be done regardless when using the functions taking a TEMController as input, it can be done later.

@viljarjf viljarjf requested a review from stefsmeets November 19, 2024 13:22
@viljarjf viljarjf marked this pull request as ready for review November 19, 2024 13:22
Copy link
Member

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for finishing this! 🚀

@stefsmeets stefsmeets merged commit f72fdc8 into instamatic-dev:main Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to reflect changes in #99
2 participants