Merge branch 'main' into 145-multi-ancova

Author: gowerc

R/impute.R

@@ -820,10 +820,14 @@ validate_strategies <- function(strategies, reference) {
     for (ref in unique_references) {
         assert_that(
             ref %in% strat_names,
-            msg = sprintf("Required strategy `%s` has not been defined", ref)
+            msg = sprintf(
+                "No implementation for strategy `%s` is available. Available strategies include:\n%s",
+                ref,
+                paste(sprintf("  - %s", strat_names), collapse = "\n")
+            )
         )
     }
-    return(invisible(TRUE))
+    invisible(TRUE)
 }
 
 

tests/testthat/_snaps/impute.md

@@ -0,0 +1,10 @@
+# validate_strategies
+
+    Code
+      cat(e$message)
+    Output
+      No implementation for strategy `NMAR` is available. Available strategies include:
+        - A
+        - MAR
+        - AAA
+

tests/testthat/test-impute.R

@@ -701,6 +701,19 @@ test_that("validate_strategies", {
 
     strats <- c("NMAR")
     expect_error(validate_strategies(strats, "NMAR"))
+
+    # #513 - Test that more informative error message is created when providing an invalid
+    # strategy
+    strats <- list(
+        "A" = function(x) x,
+        "MAR" = function(x) x,
+        "AAA" = function(x) x
+    )
+    e <- tryCatch(
+        validate_strategies(strats, "NMAR"),
+        error = function(e) e
+    )
+    expect_snapshot(cat(e$message))
 })