-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-3535 MarloweBulkSync Server #724
Conversation
syncBulkPort :: CliOption OptionFields PortNumber | ||
syncBulkPort = | ||
port | ||
"marlowe-bulk" | ||
"SYNC_MARLOWE_BULK" | ||
3730 | ||
"The port number of the marlowe-sync server's bulk synchronization API." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't the operables, deployment, and compose derivations need updating, too?
In fact, should we add this reminder to the PR template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be a good way to deal with this. You're right we often forget this. I can't really think of a good way to automate this check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to finally have this API.
However, marlowe-finder
does not report about 30% of the contracts on preprod
:
$ marlowe-finder --end-at-tip \
| jq -r 'select(.NewContract) | .NewContract.fields.contractId \
| (.txId + "#" + (.txIx | tostring))' \
| wc -l
5123
$ psql preprod
preprod=> select count(*) from marlowe.createtxout;
count
-------
7055
(1 row)
The situation is more serious on
|
Thanks for performing that test, I'll investigate! |
b504618
to
4e9906a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhbertra, I reran the tests on the new commit and results are correct both on preprod
and preview
.
marlowe-sync
Pre-submit checklist: