Conversation
added 10 commits
September 29, 2023 09:38
bwbush
reviewed
Oct 4, 2023
Comment on lines
+52
to
+58
| syncBulkPort :: CliOption OptionFields PortNumber | ||
| syncBulkPort = | ||
| port | ||
| "marlowe-bulk" | ||
| "SYNC_MARLOWE_BULK" | ||
| 3730 | ||
| "The port number of the marlowe-sync server's bulk synchronization API." |
Collaborator
There was a problem hiding this comment.
Won't the operables, deployment, and compose derivations need updating, too?
In fact, should we add this reminder to the PR template?
Contributor
Author
There was a problem hiding this comment.
That might be a good way to deal with this. You're right we often forget this. I can't really think of a good way to automate this check.
bwbush
previously requested changes
Oct 4, 2023
Collaborator
bwbush
left a comment
There was a problem hiding this comment.
It's great to finally have this API.
However, marlowe-finder does not report about 30% of the contracts on preprod:
$ marlowe-finder --end-at-tip \
| jq -r 'select(.NewContract) | .NewContract.fields.contractId \
| (.txId + "#" + (.txIx | tostring))' \
| wc -l
5123
$ psql preprod
preprod=> select count(*) from marlowe.createtxout;
count
-------
7055
(1 row)
Collaborator
|
The situation is more serious on |
Contributor
Author
|
Thanks for performing that test, I'll investigate! |
b504618 to
4e9906a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marlowe-syncPre-submit checklist: