Skip to content

Catalyst Signed Docs parameters field. #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mr-Leshiy opened this issue May 6, 2025 · 0 comments · Fixed by #317
Closed

Catalyst Signed Docs parameters field. #307

Mr-Leshiy opened this issue May 6, 2025 · 0 comments · Fixed by #317
Assignees
@Mr-Leshiy
Labels
F14-RC2 F14

Comments

@Mr-Leshiy
Copy link
Contributor

Mr-Leshiy commented May 6, 2025 •
edited
Loading

Summary

Add a new parameters metadata field, which should be basically a replacement of the category_id, election_id, campaign_id, brand_id.

Description

Update ExtraFields structure, remove existing category_id, election_id, campaign_id and brand_id fields. Add new parameters field which should have the following defintion

    /// Reference to the parameters document.
    #[serde(skip_serializing_if = "Option::is_none")]
    parameters: Option<DocumentRef>,
@Mr-Leshiy Mr-Leshiy moved this from New to 🔖 Ready in Catalyst May 6, 2025
@vlopes11 vlopes11 moved this from 🔖 Ready to 🏗 In progress in Catalyst May 6, 2025
@vlopes11 vlopes11 self-assigned this May 6, 2025
vlopes11 added a commit that referenced this issue May 13, 2025
@vlopes11
refactor(rust/signed_doc): add parameters field
7039acf 
This commit replaces the ad-hoc attributes (category_id, election_id,
campaign_id, brand_id) for a single `parameters` field, that is expected
to hold document-specific validation rules.

It is in accordance to the architecture specs
https://input-output-hk.github.io/catalyst-libs/architecture/08_concepts/signed_doc/spec/

Closes #307
@vlopes11 vlopes11 mentioned this issue May 13, 2025
Merged
8 tasks
vlopes11 added a commit that referenced this issue May 13, 2025
@vlopes11
refactor(rust/signed-doc): add parameters field
6c98077 
This commit replaces the ad-hoc attributes (category_id, election_id,
campaign_id, brand_id) for a single `parameters` field, that is expected
to hold document-specific validation rules.

It is in accordance to the architecture specs
https://input-output-hk.github.io/catalyst-libs/architecture/08_concepts/signed_doc/spec/

Closes #307
@vlopes11 vlopes11 mentioned this issue May 13, 2025
Closed
8 tasks
@Mr-Leshiy Mr-Leshiy assigned Mr-Leshiy and unassigned vlopes11 May 15, 2025
stevenj pushed a commit that referenced this issue May 19, 2025
@vlopes11 @Mr-Leshiy @no30bit
refactor(rust/signed-doc): add parameters field (#317)
b573bff 
* refactor(rust/signed-doc): add parameters field

This commit replaces the ad-hoc attributes (category_id, election_id,
campaign_id, brand_id) for a single `parameters` field, that is expected
to hold document-specific validation rules.

It is in accordance to the architecture specs
https://input-output-hk.github.io/catalyst-libs/architecture/08_concepts/signed_doc/spec/

Closes #307

* Update rust/signed_doc/src/validator/mod.rs

* wip

* wip

* wip

* fix spelling

* fix clippy

* wip

* pedantic suggestion (#327)

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>
Co-authored-by: Artur Helmanau <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🔬 Ready For QA in Catalyst May 19, 2025
@Mr-Leshiy Mr-Leshiy moved this from 🔬 Ready For QA to ✅ Done in Catalyst May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mr-Leshiy Mr-Leshiy

Labels
F14-RC2 F14
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rust/signed-doc): add parameters field input-output-hk/catalyst-libs
2 participants
@vlopes11 @Mr-Leshiy