From c5642221d670b608ca3072cc1bd10b57be09d5e1 Mon Sep 17 00:00:00 2001 From: Anna Carroll Date: Mon, 22 Sep 2025 15:16:51 -0400 Subject: [PATCH 1/2] tweak for fork testing --- test/rollup/Orders.t.sol | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/rollup/Orders.t.sol b/test/rollup/Orders.t.sol index df10eb0..e0b9931 100644 --- a/test/rollup/Orders.t.sol +++ b/test/rollup/Orders.t.sol @@ -149,17 +149,20 @@ contract OrdersTest is SignetStdTest { } function test_sweepETH() public { + uint256 prevBalance = address(target).balance; + // initiate an ETH order inputs[0].token = address(0); target.initiate{value: amount}(deadline, inputs, outputs); - assertEq(address(target).balance, amount); + assertEq(address(target).balance, prevBalance + amount); // sweep ETH vm.expectEmit(); emit Sweep(recipient, address(0), amount); target.sweep(recipient, address(0), amount); + assertEq(address(target).balance, prevBalance); assertEq(recipient.balance, amount); } From e427a934f8428b7710f2a734925c1f25229a2ac9 Mon Sep 17 00:00:00 2001 From: Anna Carroll Date: Mon, 22 Sep 2025 15:20:25 -0400 Subject: [PATCH 2/2] fix: fmt and snapshot --- .gas-snapshot | 55 +--------------------------------------- test/rollup/Orders.t.sol | 2 +- 2 files changed, 2 insertions(+), 55 deletions(-) diff --git a/.gas-snapshot b/.gas-snapshot index 2232958..07b0353 100644 --- a/.gas-snapshot +++ b/.gas-snapshot @@ -3,20 +3,6 @@ OrderOriginPermit2Test:test_fillPermit2() (gas: 174723) OrderOriginPermit2Test:test_fillPermit2_multi() (gas: 510586) OrderOriginPermit2Test:test_initiatePermit2() (gas: 187081) OrderOriginPermit2Test:test_initiatePermit2_multi() (gas: 470943) -OrdersForkTest:test_fill_ERC20() (gas: 74581) -OrdersForkTest:test_fill_ETH() (gas: 71687) -OrdersForkTest:test_fill_both() (gas: 175984) -OrdersForkTest:test_fill_multiETH() (gas: 138365) -OrdersForkTest:test_fill_underflowETH() (gas: 118654) -OrdersForkTest:test_initiate_ERC20() (gas: 87520) -OrdersForkTest:test_initiate_ETH() (gas: 49955) -OrdersForkTest:test_initiate_both() (gas: 126223) -OrdersForkTest:test_initiate_multiERC20() (gas: 183468) -OrdersForkTest:test_initiate_multiETH() (gas: 82210) -OrdersForkTest:test_orderExpired() (gas: 30996) -OrdersForkTest:test_sweepERC20() (gas: 61825) -OrdersForkTest:test_sweepETH() (gas: 85828) -OrdersForkTest:test_underflowETH() (gas: 66905) OrdersTest:test_fill_ERC20() (gas: 76273) OrdersTest:test_fill_ETH() (gas: 73740) OrdersTest:test_fill_both() (gas: 179143) @@ -29,21 +15,8 @@ OrdersTest:test_initiate_multiERC20() (gas: 186451) OrdersTest:test_initiate_multiETH() (gas: 86339) OrdersTest:test_orderExpired() (gas: 32846) OrdersTest:test_sweepERC20() (gas: 62965) -OrdersTest:test_sweepETH() (gas: 89995) +OrdersTest:test_sweepETH() (gas: 90833) OrdersTest:test_underflowETH() (gas: 69404) -PassageForkTest:test_configureEnter() (gas: 141651) -PassageForkTest:test_disallowedEnter() (gas: 58928) -PassageForkTest:test_enter() (gas: 26523) -PassageForkTest:test_enterToken() (gas: 66880) -PassageForkTest:test_enterToken_defaultChain() (gas: 65384) -PassageForkTest:test_enter_defaultChain() (gas: 24949) -PassageForkTest:test_fallback() (gas: 22784) -PassageForkTest:test_onlyTokenAdmin() (gas: 19145) -PassageForkTest:test_receive() (gas: 22222) -PassageForkTest:test_setUp() (gas: 23289) -PassageForkTest:test_withdraw() (gas: 64486) -PassagePermit2ForkTest:test_disallowedEnterPermit2() (gas: 1133422) -PassagePermit2ForkTest:test_enterTokenPermit2() (gas: 150565) PassagePermit2Test:test_disallowedEnterPermit2() (gas: 1130187) PassagePermit2Test:test_enterTokenPermit2() (gas: 150794) PassageTest:test_configureEnter() (gas: 141651) @@ -57,28 +30,11 @@ PassageTest:test_onlyTokenAdmin() (gas: 19145) PassageTest:test_receive() (gas: 22222) PassageTest:test_setUp() (gas: 23289) PassageTest:test_withdraw() (gas: 64486) -Permit2OrdersForkTest:test_fillPermit2() (gas: 168424) -Permit2OrdersForkTest:test_fillPermit2_multi() (gas: 500785) -Permit2OrdersForkTest:test_initiatePermit2() (gas: 179960) -Permit2OrdersForkTest:test_initiatePermit2_multi() (gas: 465362) -RollupPassageForkTest:test_exit() (gas: 22860) -RollupPassageForkTest:test_exitToken() (gas: 53288) -RollupPassageForkTest:test_fallback() (gas: 20803) -RollupPassageForkTest:test_receive() (gas: 20286) -RollupPassagePermit2ForkTest:test_exitTokenPermit2() (gas: 131368) RollupPassagePermit2Test:test_exitTokenPermit2() (gas: 135717) RollupPassageTest:test_exit() (gas: 23114) RollupPassageTest:test_exitToken() (gas: 53266) RollupPassageTest:test_fallback() (gas: 20910) RollupPassageTest:test_receive() (gas: 20393) -TransactForkTest:test_configureGas() (gas: 27486) -TransactForkTest:test_enterTransact() (gas: 127464) -TransactForkTest:test_onlyGasAdmin() (gas: 9895) -TransactForkTest:test_setUp() (gas: 23757) -TransactForkTest:test_transact() (gas: 107567) -TransactForkTest:test_transact_defaultChain() (gas: 106574) -TransactForkTest:test_transact_globalGasLimit() (gas: 117828) -TransactForkTest:test_transact_perTransactGasLimit() (gas: 34574) TransactTest:test_configureGas() (gas: 27486) TransactTest:test_enterTransact() (gas: 127464) TransactTest:test_onlyGasAdmin() (gas: 9895) @@ -87,15 +43,6 @@ TransactTest:test_transact() (gas: 107567) TransactTest:test_transact_defaultChain() (gas: 106574) TransactTest:test_transact_globalGasLimit() (gas: 117828) TransactTest:test_transact_perTransactGasLimit() (gas: 34574) -ZenithForkTest:test_addSequencer() (gas: 81516) -ZenithForkTest:test_badSignature() (gas: 46355) -ZenithForkTest:test_incorrectHostBlock() (gas: 42276) -ZenithForkTest:test_notSequencer() (gas: 39566) -ZenithForkTest:test_notSequencerAdmin() (gas: 11279) -ZenithForkTest:test_onePerBlock() (gas: 61287) -ZenithForkTest:test_removeSequencer() (gas: 50114) -ZenithForkTest:test_setUp() (gas: 8035) -ZenithForkTest:test_submitBlock() (gas: 53334) ZenithTest:test_addSequencer() (gas: 98616) ZenithTest:test_badSignature() (gas: 46355) ZenithTest:test_incorrectHostBlock() (gas: 42276) diff --git a/test/rollup/Orders.t.sol b/test/rollup/Orders.t.sol index e0b9931..e1626d5 100644 --- a/test/rollup/Orders.t.sol +++ b/test/rollup/Orders.t.sol @@ -149,7 +149,7 @@ contract OrdersTest is SignetStdTest { } function test_sweepETH() public { - uint256 prevBalance = address(target).balance; + uint256 prevBalance = address(target).balance; // initiate an ETH order inputs[0].token = address(0);