From 36992c9c13d917450de57c98a1fc4da413447d50 Mon Sep 17 00:00:00 2001 From: James Date: Fri, 1 Aug 2025 15:51:53 -0400 Subject: [PATCH 1/3] feat: node types readme --- crates/node-types/README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 crates/node-types/README.md diff --git a/crates/node-types/README.md b/crates/node-types/README.md new file mode 100644 index 0000000..61ddffc --- /dev/null +++ b/crates/node-types/README.md @@ -0,0 +1,10 @@ +# Signet Node Types + +This crate provides parameterizations and conveneniences for the Signet node's +use of reth's internal generics. E.g. [`NodePrimitives`] and [`NodeTypes`]. + +It also provides a [`NodeTypesDbTrait`] to aggregate several trait constraints +on the database type. This is then used in the node and in `signet-db`. + +This crate is mostly shims. It is not intended to be used outside of the +Signet node and `signet-db` crates. From edafb229dbec0436105eacbcbb5284d87af3507e Mon Sep 17 00:00:00 2001 From: James Date: Fri, 1 Aug 2025 15:53:11 -0400 Subject: [PATCH 2/3] fix: lints in node-types --- crates/node-types/Cargo.toml | 1 - crates/node-types/src/lib.rs | 14 +++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/crates/node-types/Cargo.toml b/crates/node-types/Cargo.toml index b097e17..41d509c 100644 --- a/crates/node-types/Cargo.toml +++ b/crates/node-types/Cargo.toml @@ -15,6 +15,5 @@ reth-db.workspace = true reth-node-api.workspace = true reth-node-ethereum.workspace = true reth-trie-db.workspace = true -reth-prune-types.workspace = true tokio.workspace = true \ No newline at end of file diff --git a/crates/node-types/src/lib.rs b/crates/node-types/src/lib.rs index 22a5733..251d995 100644 --- a/crates/node-types/src/lib.rs +++ b/crates/node-types/src/lib.rs @@ -1,4 +1,16 @@ -//! Types used by the signet node +#![doc = include_str!("../README.md")] +#![warn( + missing_copy_implementations, + missing_debug_implementations, + missing_docs, + unreachable_pub, + clippy::missing_const_for_fn, + rustdoc::all +)] +#![cfg_attr(not(test), warn(unused_crate_dependencies))] +#![deny(unused_must_use, rust_2018_idioms)] +#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] + use reth::{ primitives::EthPrimitives, providers::{ From 68333902b6c381f7287d70025ba5134378ac5ecc Mon Sep 17 00:00:00 2001 From: James Date: Fri, 1 Aug 2025 15:54:41 -0400 Subject: [PATCH 3/3] nit: remove codeowners funny --- .github/CODEOWNERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 024cb87..ac38313 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,2 @@ * @init4tech/engineering -.github/workflows @rswanson -crates/zenith/abi @anna-carroll \ No newline at end of file +.github/workflows @rswanson \ No newline at end of file