You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm just noting a possible issue. Wouldn't this line cause frequent extensions of the client.currentMessage.Streams, which would cause reallocations and slowdown? My recent performance tests didn't confirm this, but we might want to keep this in mind for the future.
The text was updated successfully, but these errors were encountered:
Allocations happen exponentially, so first its 1 item slice, then 2 item slice then 4 item slice, etc. So there is space allocated in advance. But yes if we would know the final count of items, then it would be better to allocate once instead. But I believe we don't know the count.
apputils/connector/loki/loki.go
Line 245 in 3573b29
I'm just noting a possible issue. Wouldn't this line cause frequent extensions of the
client.currentMessage.Streams
, which would cause reallocations and slowdown? My recent performance tests didn't confirm this, but we might want to keep this in mind for the future.The text was updated successfully, but these errors were encountered: