Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Improve mempool of Starknet test app #801

Open
4 tasks
romac opened this issue Jan 23, 2025 · 1 comment · May be fixed by #821
Open
4 tasks

code: Improve mempool of Starknet test app #801

romac opened this issue Jan 23, 2025 · 1 comment · May be fixed by #821
Assignees
@oakenknight
Labels
application Related to building applications on top of Malachite
Milestone
Phase 5

Comments

@romac
Copy link
Member

romac commented Jan 23, 2025

Our current mempool for the Starknet mock app is quite barebones and could use a few improvements, namely:

  • Split out tx generation out of the Mempool actor and into its own actor (MempoolLoad or something)
  • After a block is decided, only remove txs that were included in that block
  • Allow configuring the MempoolLoad actor to generate load on the mempool in various ways
    • No load
    • Uniform load configured in TPS (transactions per second)
    • Non-uniform load to simulate peaks in tx ingestion, the frequency and amplitude of these peaks should be configurable
  • Allow size of generated transactions to be configured (constant, uniformly distributed, other distributions)
@romac romac added the application Related to building applications on top of Malachite label Jan 23, 2025
@romac romac added this to the Phase 5 milestone Jan 23, 2025
@cason
Copy link
Contributor

cason commented Jan 24, 2025

Another way to produce load is to emulate what we call a "closed-loop client".

Namely, we tell the number of clients we want to emulate. A client submits a tx, wait until it is decided, then submits another txs, possibly after a (configurable, random, small?) sleep.

In other words, the number of emulated clients is the maximum number of outstanding requests in the system at any time.

@oakenknight oakenknight linked a pull request Jan 30, 2025 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oakenknight oakenknight

Labels
application Related to building applications on top of Malachite
Projects
None yet
Milestone
Phase 5
Development

Successfully merging a pull request may close this issue.

feat(code/starknet): Add mempool load generator to the Starknet test app oakenknight/malachite
3 participants
@romac @cason @oakenknight