Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize lazy load spinner #555

Open
drdelambre opened this issue Jan 25, 2021 · 1 comment
Open

normalize lazy load spinner #555

drdelambre opened this issue Jan 25, 2021 · 1 comment
Labels
kind/tech-debt team/ui

Comments

@drdelambre
Copy link
Contributor

seems that we've got a bit of a divergence around what spinner is used in suspense components from the recent lazy loading efforts. Some use PageSpinner, some use SpinnerComponent. It doesn't matter which we use, they should just be consistent unless we have a good reason to support multiple interfaces
@drdelambre drdelambre mentioned this issue Jan 25, 2021
Merged
@genehynson
Copy link
Contributor

<PageSpinner/>!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/tech-debt team/ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drdelambre @genehynson