-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks #313
base: main
Are you sure you want to change the base?
Tasks #313
Conversation
2efdf64
to
bc64aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need the build working here
f142097
to
65f4dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json lock should not be changed |
which script have you used to test the upload? |
I have the docs locally. I'll push it tomorrow. The only thing I'm missing is the tooltip. I'm not sure what to put there. |
@dpanshug needs rebase |
I need some hint what to put in the tooltip. https://infinispan.org/docs/stable/titles/server/server.html#remote-execution I see the tasks can be scripts or custom Java classes. Is it necessary to stop the server? etc. |
2bf5393
to
f98bdfd
Compare
@dvagnero need to merge your commit with mine for some changes |
@dpanshug let me know when this is ready again plz |
Writing a E2E test for this. |
@tristantarrant can you help here pls. |
docs suggestions for tasks ISPN-14305
f98bdfd
to
39dcef7
Compare
@andyuk1986 Added a cypress test, pls review :) |
2fd1617
to
4269b61
Compare
Cypress test looks good but scenario for task edit/save is not there. |
4269b61
to
7931b6e
Compare
@dvagnero Found this in documentation
Maybe this info is useful for the tooltip. |
Okay so it can be Java or Javascript. What about requirements? Having a script engine? Anything else? |
For the JS task, you will need to install a JS script engine on the server, it won't work with JDK 17. |
Thank you for suggestions @dpanshug |
If it's a Java task, yes. Script tasks can be added at runtime |
@dvagnero just to add my two cents - as @tristantarrant said, there are 2 types of tasks: remote server tasks and Script Tasks. Console shows both Remote and Script Tasks. But at the moment (with this PR) it is possible to create/edit/execute only Script Tasks, and - no, for these tasks no Server restart is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When the task creation gives an error, the error should be displayed in the top of the popup and not in the alert. Otherwise we lose what we wrote in the editor.
First validate that the task was created, and if it's ok, close the popup and display an alert of ok. - The task list should display the task that has been created
If the user can't see the task, we should not be displaying any alert but only listing the names of the tasks and disable the actions the user can't do.
Thanks @andyuk1986 for the explanation. I was under the impression that we're aiming for both tasks and scripts. |
There is no way to upload a Java task: it needs to be deployed before startup |
@karesti I've tried fixing it, list gets updated when there already exist some tasks. But if you try to create the task for the first time, the API seems to not fetch the tasks list without refreshing separately. Can you please help me out here. :) |
Hi @dpanshug I changed the tooltip. Let me know if you need anything or if you make any changes that require docs :) |
@dpanshug check how the entries add works plz |
fd9eff5
to
aebcd5a
Compare
@karesti Pls check if this can be merged :) |
@dpanshug no, this feature can't be merged as it is. if the javascript engine is not available, we should disable the task creation. it is confusing and useless. for that we need an endpoint in the scripts that indicates that an js engine is available. |
Closes #516
Execute a task: https://issues.redhat.com/browse/ISPN-14305
Create a task: https://issues.redhat.com/browse/ISPN-12091
Update a task: https://issues.redhat.com/browse/ISPN-14304