Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto removing tailing / in the worker URL by auto-correction #288

Closed
longquanzheng opened this issue Jun 28, 2023 · 3 comments · Fixed by #533
Closed

Auto removing tailing / in the worker URL by auto-correction #288

longquanzheng opened this issue Jun 28, 2023 · 3 comments · Fixed by #533
Labels
good first issue Good for newcomers in-review Learning small but useful small

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Jun 28, 2023 •
edited
Loading

Sometimes user would put
http://localhost:8080/iwfWorker/
as URL which will have errors, because it will be appended to the state APIs, like :

http://localhost:8080/iwfWorker//api/v1/workflowState/start

Because common to run into just remove the tailing / as auto-correction on the server.
@sajdakabir
Copy link

hey @longquanzheng can i work on this issue?

@longquanzheng
Copy link
Contributor Author

Yeah sure ! Go ahead

@d-vignesh
Copy link

Hi @longquanzheng ,i would like to work on this issue. Can you please provide some context on the required changes.

@longquanzheng longquanzheng added the Learning small but useful label Sep 11, 2024
@longquanzheng longquanzheng changed the title allow tailing / in the worker URL by auto-correction Auto removing tailing / in the worker URL by auto-correction Sep 24, 2024
@N-give N-give mentioned this issue Jan 15, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers in-review Learning small but useful small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IWF-121 remove all trailing / from worker url indeedeng/iwf
4 participants
@longquanzheng @mixydubs @d-vignesh @sajdakabir