Fix poor iOS permissions error message #633
Conversation
- check for conditions that produce a device error instead of a permissions error, reporting the correct error
There was a problem hiding this comment.
Hello,
and thank you for your contribution.
I have not yet looked at the code yet, because:
This does work on iOS in the following sense: When you have the app installed, change the app settings to not give permissions for the camera, then open the camera, it does show the correct error message now.
However, on my test devices it does not work for the very first time you navigate to the camera after a fresh install and press Disable/Not Allow in the native camera permission modal. The camera component just stays black with no error message. I realize that it was like this before your PR already, so we can still merge your changes in and post another issue about this. Or if you want you could have a stab at it.
Anyways, on Android, on my test device, now when navigating to the camera on a fresh install and pressing Disable/Not Allow on the native camera permission modal, the app crashes and quits. Before your PR the app showed the "no permission" error text succesfully in this circumstance, so this PR would need to make sure not to break this behaviour.
|
I have included those changes in a different PR where I also updated the vision-camera library. Closing this one here. |
This PR fixes #624 by adding another condition under which a permissions error is reported.
On iOS, if camera permissions are turned off in settings, react-native-vision-camera will send a
device/invalid-deviceerror followed by a number ofsession/camera-not-readyerrors. If either of those errors are encountered and camera permissions are disabled, a permissions error is reported instead of a device or session error.