chore(deps): Update oidc-client-ts to the latest version (#2746)

Author: rodrigo-fournier-immutable

packages/internal/toolkit/package.json

@@ -13,7 +13,7 @@
     "enc-utils": "^3.0.0",
     "ethers": "^6.13.4",
     "magic-sdk": "^29.0.5",
-    "oidc-client-ts": "3.3.0"
+    "oidc-client-ts": "3.4.1"
   },
   "devDependencies": {
     "@swc/core": "^1.3.36",

packages/passport/sdk/package.json

@@ -22,7 +22,7 @@
     "jwt-decode": "^3.1.2",
     "localforage": "^1.10.0",
     "magic-sdk": "^29.0.5",
-    "oidc-client-ts": "3.3.0",
+    "oidc-client-ts": "3.4.1",
     "uuid": "^8.3.2"
   },
   "devDependencies": {

packages/passport/sdk/src/authManager.test.ts

@@ -237,90 +237,6 @@ describe('AuthManager', () => {
       });
     });
 
-    describe('popup closed detection', () => {
-      let mockPopupRef: any;
-      let mockSetInterval: jest.SpyInstance;
-      let mockClearInterval: jest.SpyInstance;
-
-      beforeEach(() => {
-        mockPopupRef = {
-          closed: false,
-          close: jest.fn(),
-        };
-
-        // Override the global mock for these tests
-        (window.open as jest.Mock).mockReturnValue(mockPopupRef);
-
-        mockSetInterval = jest.spyOn(global, 'setInterval');
-        mockClearInterval = jest.spyOn(global, 'clearInterval');
-      });
-
-      afterEach(() => {
-        mockSetInterval.mockRestore();
-        mockClearInterval.mockRestore();
-      });
-
-      it('should reject with "Popup closed by user" when popup is closed during authentication', async () => {
-        // Mock signinPopup to return a promise that never resolves (simulating long authentication)
-        const signinPromise = new Promise<any>(() => {
-          // Promise never resolves to simulate ongoing authentication
-        });
-        mockSigninPopup.mockReturnValue(signinPromise);
-
-        // Start the login process
-        const loginPromise = authManager.login();
-
-        // Wait for the polling to be set up
-        await new Promise((resolve) => {
-          setTimeout(resolve, 10);
-        });
-
-        // Verify polling was set up
-        expect(mockSetInterval).toHaveBeenCalledWith(expect.any(Function), 500);
-
-        // Get the polling function and simulate popup being closed
-        const pollingCallback = mockSetInterval.mock.calls[0][0];
-        mockPopupRef.closed = true;
-        pollingCallback(); // Manually trigger the polling callback
-
-        // Expect the login to reject with popup closed error
-        await expect(loginPromise).rejects.toThrow('Popup closed by user');
-      });
-
-      it('should clean up timer when user authentication completes successfully', async () => {
-        mockSigninPopup.mockResolvedValue(mockOidcUser);
-
-        await authManager.login();
-
-        // Verify timer was cleared
-        expect(mockClearInterval).toHaveBeenCalled();
-        // Verify popup was closed
-        expect(mockPopupRef.close).toHaveBeenCalled();
-      });
-
-      it('should fall back to original behavior when popup reference is not available', async () => {
-        // Mock window.open to return null (popup blocked or failed)
-        (window.open as jest.Mock).mockReturnValue(null);
-        mockSigninPopup.mockResolvedValue(mockOidcUser);
-
-        const result = await authManager.login();
-
-        expect(result).toEqual(mockUser);
-        // Should not set up polling when no popup reference
-        expect(mockSetInterval).not.toHaveBeenCalled();
-      });
-
-      it('should use correct polling duration constant', async () => {
-        const neverResolvingPromise = new Promise(() => { });
-        mockSigninPopup.mockReturnValue(neverResolvingPromise);
-
-        authManager.login().catch(() => { }); // Ignore rejection for this test
-
-        // Verify the polling interval uses the correct constant (500ms)
-        expect(mockSetInterval).toHaveBeenCalledWith(expect.any(Function), 500);
-      });
-    });
-
     describe('when the user has registered for imx', () => {
       it('should populate the imx object', async () => {
         mockSigninPopup.mockResolvedValue(mockOidcUser);

packages/passport/sdk/src/authManager.ts

@@ -32,8 +32,6 @@ import ConfirmationOverlay from './overlay/confirmationOverlay';
 import { LocalForageAsyncStorage } from './storage/LocalForageAsyncStorage';
 import { EmbeddedLoginPrompt } from './confirmation';
 
-const LOGIN_POPUP_CLOSED_POLLING_DURATION = 500;
-
 const formUrlEncodedHeader = {
   headers: {
     'Content-Type': 'application/x-www-form-urlencoded',
@@ -259,44 +257,14 @@ export default class AuthManager {
       const signinPopup = async () => {
         const extraQueryParams = this.buildExtraQueryParams(anonymousId, directLoginOptionsToUse, imPassportTraceId);
 
-        const userPromise = this.userManager.signinPopup({
+        return this.userManager.signinPopup({
           extraQueryParams,
           popupWindowFeatures: {
             width: 410,
             height: 450,
           },
           popupWindowTarget,
         });
-
-        // ID-3950: https://github.com/authts/oidc-client-ts/issues/2043
-        // The promise returned from `signinPopup` no longer rejects when the popup is closed.
-        // We can prevent this from impacting consumers by obtaining a reference to the popup and rejecting the promise
-        // that is returned by this method if the popup is closed by the user.
-
-        // Attempt to get a reference to the popup window
-        const popupRef = window.open('', popupWindowTarget);
-        if (popupRef) {
-          // Create a promise that rejects when popup is closed
-          const popupClosedPromise = new Promise<never>((_, reject) => {
-            const timer = setInterval(() => {
-              if (popupRef.closed) {
-                clearInterval(timer);
-                reject(new Error('Popup closed by user'));
-              }
-            }, LOGIN_POPUP_CLOSED_POLLING_DURATION);
-
-            // Clean up timer when the user promise resolves/rejects
-            userPromise.finally(() => {
-              clearInterval(timer);
-              popupRef.close();
-            });
-          });
-
-          // Race between user authentication and popup being closed
-          return Promise.race([userPromise, popupClosedPromise]);
-        }
-
-        return userPromise;
       };
 
       // This promise attempts to open the signin popup, and displays the blocked popup overlay if necessary.
@@ -360,33 +328,8 @@ export default class AuthManager {
     return user || this.login();
   }
 
-  private static shouldUseSigninPopupCallback(): boolean {
-    // ID-3950: https://github.com/authts/oidc-client-ts/issues/2043
-    // Detect when the login was initiated via a popup
-    try {
-      const urlParams = new URLSearchParams(window.location.search);
-      const stateParam = urlParams.get('state');
-      const localStorageKey = `oidc.${stateParam}`;
-
-      const localStorageValue = localStorage.getItem(localStorageKey);
-      const loginState = JSON.parse(localStorageValue || '{}');
-
-      return loginState?.request_type === 'si:p';
-    } catch (err) {
-      return false;
-    }
-  }
-
   public async loginCallback(): Promise<undefined | User> {
     return withPassportError<undefined | User>(async () => {
-      // ID-3950: https://github.com/authts/oidc-client-ts/issues/2043
-      // When using `signinPopup` to initiate a login, call the `signinPopupCallback` method and
-      // set the `keepOpen` flag to `true`, as the `login` method is now responsible for closing the popup.
-      // See the comment in the `login` method for more details.
-      if (AuthManager.shouldUseSigninPopupCallback()) {
-        await this.userManager.signinPopupCallback(undefined, true);
-        return undefined;
-      }
       const oidcUser = await this.userManager.signinCallback();
       if (!oidcUser) {
         return undefined;

packages/x-provider/package.json

@@ -15,7 +15,7 @@
     "enc-utils": "^3.0.0",
     "ethers": "^6.13.4",
     "magic-sdk": "^29.0.5",
-    "oidc-client-ts": "3.3.0"
+    "oidc-client-ts": "3.4.1"
   },
   "devDependencies": {
     "@swc/core": "^1.3.36",