match(urlRegex:) function and the init of HTTPStubRegExMatcher() does not throws in case of wrong regular expression pattern

[haemi]

I use several stubs, just implemented the third one and now running into problems:

extension HTTPStubRequest {
    static var stubXY: HTTPStubRequest {
        HTTPStubRequest().match(urlRegex: "*/resources/user/*/info").stub(for: .get) { urlRequest, matchedStubRequest in

        // getting here for the url https://example.com/resources/public/countries
        ...
        }
    }
}

This should never be the case, right? I'm having another stub added before this that should handle this case.

[malcommac]

There was a logic error because match(urlRegex:) function and the init of HTTPStubRegExMatcher() should throw in case of the wrong regex pattern. It does not happen and it silently fails without adding the right matcher to the stub request object it creates.

The right regex could be (?s).*\/resources\/user\/(?s).*\/info.

An example with the fixes for throws in the commits above.

do {
  let stub = try HTTPStubRequest().match(urlRegex: "(?s).*/resources/user/(?s).*/info").stub(for: .post) { urlRequest, matchedStubRequest in
    // it captures the https://example.com/resources/user/searches/info
   // but not https://example.com/resources/list/searches/info (for example)
    HTTPStubResponse()
  }
  HTTPStubber.shared.add(stub: stub)
            
  let req = HTTPRequest {
    $0.url = URL(string: "https://example.com/resources/user/searches/info")
    $0.method = .post
  }
            
  let newClient = HTTPClient(baseURL: nil)
  let response = try await req.fetch(newClient)
} catch {
  print("Failed to add stub due to an error: \(error))
}

[malcommac]

Obviously even the * in tests is wrong; it should be (?s).* (fixed)

[haemi]

you rock, thanks a LOT!